You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Jason Gerlowski (JIRA)" <ji...@apache.org> on 2018/10/12 14:45:00 UTC
[jira] [Commented] (SOLR-6312) CloudSolrServer doesn't honor
updatesToLeaders constructor argument
[ https://issues.apache.org/jira/browse/SOLR-6312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16647987#comment-16647987 ]
Jason Gerlowski commented on SOLR-6312:
---------------------------------------
Wanted to re-bring this to people's attention if I could. It's gotta be really confusing for our users that {{CloudSolrClient.Builder}} has 4 different methods all involving how updates are sent to shards. None of them are well documented, and 2 of them have had no effect for the last 4 years or so.
I came to this because I wanted to add Javadocs to these methods and was surprised to find that they don't do anything. I felt like it would be a little silly to have javadocs saying: "These methods don't have any effect. They used to have an effect, but now we're just keeping them around as a vestigial organ", so I thought I would maybe poke this thread again.
I don't have a strong preference what we do with these methods. I buy Steve's and Hoss' point that having this setting would be beneficial for those doing work in their update-request-chains that they want to spread around different nodes. But it's unclear when someone will have the time/priority to make this happen and in the meantime I'd hate to see us let the "perfect" (this cool new functionality) get in the way of the "good" (less confusing interface).
Would anyone care if I added a deprecation warning to these methods? Deprecation doesn't need to be final...if someone gets around to implementing this functionality, we can always remove the deprecation. We should do _something_ to steer users away from using the methods in their current state. I'd vote for temporary-deprecation since that catches the eye a little more than a Javadoc that you don't see unless think to go look it up. But if others still object I'll just add a little javadoc warning.
> CloudSolrServer doesn't honor updatesToLeaders constructor argument
> -------------------------------------------------------------------
>
> Key: SOLR-6312
> URL: https://issues.apache.org/jira/browse/SOLR-6312
> Project: Solr
> Issue Type: Bug
> Components: clients - java, SolrJ
> Affects Versions: 4.9, 7.5
> Reporter: Steve Davids
> Priority: Major
> Fix For: 4.10
>
> Attachments: SOLR-6312.patch
>
>
> The CloudSolrServer doesn't use the updatesToLeaders property - all SolrJ requests are being sent to the shard leaders.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org