You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@celeborn.apache.org by zh...@apache.org on 2023/03/24 08:05:53 UTC

[incubator-celeborn] branch main updated: [CELEBORN-471] Fix String.format wrong type in ShuffleClientImpl (#1378)

This is an automated email from the ASF dual-hosted git repository.

zhouky pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-celeborn.git


The following commit(s) were added to refs/heads/main by this push:
     new 2adbce942 [CELEBORN-471] Fix String.format wrong type in ShuffleClientImpl (#1378)
2adbce942 is described below

commit 2adbce942abc4199daae14dd207d72f26b73fb24
Author: cxzl25 <cx...@users.noreply.github.com>
AuthorDate: Fri Mar 24 16:05:48 2023 +0800

    [CELEBORN-471] Fix String.format wrong type in ShuffleClientImpl (#1378)
---
 .../java/org/apache/celeborn/client/ShuffleClientImpl.java     | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/client/src/main/java/org/apache/celeborn/client/ShuffleClientImpl.java b/client/src/main/java/org/apache/celeborn/client/ShuffleClientImpl.java
index 20fc78284..efb3249c4 100644
--- a/client/src/main/java/org/apache/celeborn/client/ShuffleClientImpl.java
+++ b/client/src/main/java/org/apache/celeborn/client/ShuffleClientImpl.java
@@ -623,7 +623,7 @@ public class ShuffleClientImpl extends ShuffleClient {
           null,
           StatusCode.PUSH_DATA_FAIL_NON_CRITICAL_CAUSE)) {
         throw new CelebornIOException(
-            String.format("Revive for shuffle %d partition %d failed.", shuffleKey, partitionId));
+            String.format("Revive for shuffle %s partition %d failed.", shuffleKey, partitionId));
       }
     }
 
@@ -645,7 +645,7 @@ public class ShuffleClientImpl extends ShuffleClient {
     if (loc == null) {
       throw new CelebornIOException(
           String.format(
-              "Partition location for shuffle %d partition %d is NULL!", shuffleKey, partitionId));
+              "Partition location for shuffle %s partition %d is NULL!", shuffleKey, partitionId));
     }
 
     PushState pushState = getPushState(mapKey);
@@ -705,7 +705,7 @@ public class ShuffleClientImpl extends ShuffleClient {
             public void onFailure(Throwable e) {
               String errorMsg =
                   String.format(
-                      "Push data to %s failed for shuffle $d map %d attempt %d partition %d batch %d.",
+                      "Push data to %s failed for shuffle %d map %d attempt %d partition %d batch %d.",
                       loc, shuffleId, mapId, attemptId, partitionId, nextBatchId);
               pushState.exception.compareAndSet(null, new CelebornIOException(errorMsg, e));
             }
@@ -1356,13 +1356,13 @@ public class ShuffleClientImpl extends ShuffleClient {
           logger.warn(
               "Request {} return {} for {}.",
               getReducerFileGroup,
-              StatusCode.STAGE_END_TIME_OUT.toString(),
+              StatusCode.STAGE_END_TIME_OUT,
               shuffleKey);
         } else if (response.status() == StatusCode.SHUFFLE_DATA_LOST) {
           logger.warn(
               "Request {} return {} for {}.",
               getReducerFileGroup,
-              StatusCode.SHUFFLE_DATA_LOST.toString(),
+              StatusCode.SHUFFLE_DATA_LOST,
               shuffleKey);
         }
       } catch (Exception e) {