You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Dawid Weiss (Jira)" <ji...@apache.org> on 2021/01/30 18:55:00 UTC
[jira] [Commented] (LUCENE-9711) "gradle precommit" no longer
catches accidental package-private APIs?
[ https://issues.apache.org/jira/browse/LUCENE-9711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275693#comment-17275693 ]
Dawid Weiss commented on LUCENE-9711:
-------------------------------------
I think it's the fact the python linter has been replaced by javadoc doclet, not gradle build itself.
> "gradle precommit" no longer catches accidental package-private APIs?
> ---------------------------------------------------------------------
>
> Key: LUCENE-9711
> URL: https://issues.apache.org/jira/browse/LUCENE-9711
> Project: Lucene - Core
> Issue Type: Bug
> Affects Versions: master (9.0)
> Reporter: Michael McCandless
> Priority: Major
>
> While backporting the new exciting deterministic multi-segment indexing tool, LUCENE-9694, {{ant precommit}} failed, because the new {{DocumentSelector}} API was accidentally package private, missing its {{public}} modifier.
> [Aside: I sometimes feel we should not put unit tests in the same package as the APIs they are testing. We of course do this to make testing internal, package-private state, possible/easier. But it then leads to API bugs like this, where we fail to make an API public when it should be.]
> Anyways, luckily, the old crazy hacky Python javadoc linter in 8.x caught this issue, and I fixed it on backport, and will shortly fix it in mainline as well. But {{gradle precommit}} on mainline failed to catch it, I think?
> Is this a known regression in our {{gradle}} migration? Do we have plans to somehow recover it? It clearly sometimes catches important API bugs! And this is not the first time it's caught such bugs...
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org