You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2017/05/01 21:52:04 UTC

Re: Review Request 58761: Added --secret-fetcher flag for agent.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58761/#review173517
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/main.cpp
Line 234 (original), 243-245 (patched)
<https://reviews.apache.org/r/58761/#comment246505>

    why is this mentioned twice? what's the difference between "Secret fetcher" and "SecretFetcher" ?


- Vinod Kone


On April 28, 2017, 6:51 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58761/
> -----------------------------------------------------------
> 
> (Updated April 28, 2017, 6:51 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-7418
>     https://issues.apache.org/jira/browse/MESOS-7418
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The flag accepts a module name. The module should be specified via `--modules` or `--modules_dir` flag.
> 
> 
> Diffs
> -----
> 
>   src/local/local.cpp e47980929db2da1f31cf899a0e1fc452070e11f3 
>   src/slave/flags.hpp c7a4604ed994e15c1db6accfaded2e882f1aec94 
>   src/slave/flags.cpp c50e43c0e0ba633f6b905b0d78668c0a0eebb173 
>   src/slave/main.cpp 72b141cb66f9df5bcc7b3f8cfcc2b06fcbd17e52 
>   src/slave/slave.hpp 77fb93abc701cd34b69c75b6219c219fdb784a67 
>   src/slave/slave.cpp 8b8078dbb656e9db2efa53cc4ec5bed2cc01d49a 
> 
> 
> Diff: https://reviews.apache.org/r/58761/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>