[GitHub] [fineract-cn-mobile] jawidMuhammadi commented on a change in pull request #189: Fixes #FINCN-326 Create, update, list tellers and Teller Details implemented

[GitBox <gi...@apache.org>]

jawidMuhammadi commented on a change in pull request #189:
URL: https://github.com/apache/fineract-cn-mobile/pull/189#discussion_r654777217



##########
File path: app/src/main/res/values/strings.xml
##########
@@ -539,9 +548,22 @@
     <string name="dialog_message_confirm_name_deletion">Do you want to delete %s?</string>
     <string name="edit_group">Edit Group</string>
     <string name="updating_group_please_wait">Updating Group, please wait...</string>
+    <string name="updating_teller_please_wait">Updating Teller, please wait...</string>
     <string name="please_verify_following_group_task">Please verify the following tasks before you can %1$s this group</string>
     <string name="change_group_status">Change the status of group</string>
+    <string name="change_teller_status">Change the status of Teller</string>
     <string name="please_wait_updating_group_status">"Updating group status, please wait... "</string>
     <string name="error_while_updating_group_status">Error while updating group status</string>
     <string name="error_while_creating_group">Error while creating group</string>
+    <string name="error_while_creating_teller">Error while creating Teller</string>
+    <string name="error_while_updating_teller">Error while updating Teller</string>
+    <string name="assigned_employee">Assigned Employee</string>
+    <string name="cheaques_recievable_amount">Cheaques Recievable Amount</string>
+    <string name="cash_over_short_account">Cash over Short Account</string>
+    <string name="cash_withdraw_limit">Cash Withdraw Limit</string>
+    <string name="denomination_required">Denomination Required?</string>
+    <string name="vaultaccountidentifier">VaultAccountIdentifier</string>
+    <string name="telleraccountidentifier">TellerAccountIdentifier</string>

Review comment:
       If some texts like this will not be translated then add the `translatable = false` attribute to the strings

##########
File path: app/src/main/java/org/apache/fineract/ui/online/teller/createteller/TellerReviewStepFragment.kt
##########
@@ -0,0 +1,60 @@
+package org.apache.fineract.ui.online.teller.createteller
+
+import android.os.Bundle
+import android.view.LayoutInflater
+import android.view.View
+import android.view.ViewGroup
+import com.stepstone.stepper.Step
+import com.stepstone.stepper.VerificationError
+import kotlinx.android.synthetic.main.fragment_step_teller_review.*
+import org.apache.fineract.R
+import org.apache.fineract.data.models.teller.Teller
+import org.apache.fineract.ui.base.FineractBaseFragment
+
+/*
+ * Created by Varun Jain on 16.06.2021
+*/
+
+class TellerReviewStepFragment : FineractBaseFragment(), Step {
+
+    lateinit var rootView: View
+
+    companion object {
+        fun newInstance(): TellerReviewStepFragment {
+            return TellerReviewStepFragment()
+        }
+    }
+
+    override fun onCreateView(
+        inflater: LayoutInflater,
+        container: ViewGroup?,
+        savedInstanceState: Bundle?
+    ): View? {
+        rootView = inflater.inflate(R.layout.fragment_step_teller_review, container, false)
+        (activity as CreateTellerActivity).activityComponent.inject(this)
+
+        return rootView
+    }
+
+    private fun fillViews(teller: Teller) {
+        tv_teller_review_code.text = teller.code
+        tv_teller_review_password.text = teller.password
+        tv_teller_review_cashwithdraw_limit.text = teller.cashdrawLimit.toString()
+        tv_teller_review_acc_identifier.text = teller.tellerAccountIdentifier
+        tv_teller_review_vault_acc_identifier.text = teller.vaultAccountIdentifier
+        tv_teller_review_denomination_req.isChecked = teller.denominationRequired
+        tv_teller_review_cheaques_recievable_amount.text = teller.chequesReceivableAccount
+        tv_teller_review_cashovershortacc.text = teller.cashOverShortAccount
+        tv_teller_review_assigned_employee.text = teller.assignedEmployee

Review comment:
       Kotlin `synthetic` imports have been deprecated, so instead please use `data binding` and also it would be great if you follow the `camel case` naming style in view ids.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org