You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Maxim Solodovnik <so...@gmail.com> on 2016/11/01 16:07:12 UTC

Issue with WebSocketBehaviour in 7.5.0

Hello Martin,

WebSocketBehavior seems to be broken, I guess it is caused by [1] , but not
sure

here is quickstart: https://github.com/solomax/wicket-websocket
The error differs depending on this line [2] commented or not
This is blocker for our project :(

sorry for reporting this after release, I was on vacation :(


[1]
https://github.com/apache/wicket/commit/b6225514d9ad35a545750e2930485e212e95ca88
[2]
https://github.com/solomax/wicket-websocket/blob/master/src/main/java/org/apache/solomax/WicketApplication.java#L39

-- 
WBR
Maxim aka solomax

Re: Issue with WebSocketBehaviour in 7.5.0

Posted by Martin Grigorov <mg...@apache.org>.
On Fri, Nov 11, 2016 at 4:32 PM, Martijn Dashorst <
martijn.dashorst@gmail.com> wrote:

> On Fri, Nov 11, 2016 at 7:46 AM, Martin Grigorov <mg...@apache.org>
> wrote:
> > I don't mind.
> > If Martijn has time to do it.
>
> Next week when my presentation is done :-).
>
> I've wanted to work with Andrea to make him a release manager as well.
> A 7.6 or 7.5.1 seems like a good start :-)
>

If the scripts are not Mac specific I can do it too!


>
> Martijn
>
> >
> > Martin Grigorov
> > Wicket Training and Consulting
> > https://twitter.com/mtgrigorov
> >
> > On Thu, Nov 10, 2016 at 5:53 PM, Maxim Solodovnik <so...@gmail.com>
> > wrote:
> >
> >> 7.4.0 has this error:
> >> https://github.com/apache/wicket/commit/f4a6996aa4c3240b31ba191ef39686
> >> 4bf0dfad6c
> >> Maybe 7.5.1 is not that bad idea?
> >>
> >> On Tue, Nov 8, 2016 at 7:31 PM, Maxim Solodovnik <so...@gmail.com>
> >> wrote:
> >> > Good idea,
> >> > Thanks a lot! :)
> >> >
> >> > On Tue, Nov 8, 2016 at 7:30 PM, Martin Grigorov <mgrigorov@apache.org
> >
> >> wrote:
> >> >> You may use Wicket 7.5.0 + Wicket Native WebSocket 7.4.0
> >> >> They are binary compatible.
> >> >>
> >> >> Martin Grigorov
> >> >> Wicket Training and Consulting
> >> >> https://twitter.com/mtgrigorov
> >> >>
> >> >> On Tue, Nov 8, 2016 at 1:12 PM, Maxim Solodovnik <
> solomax666@gmail.com>
> >> >> wrote:
> >> >>
> >> >>> Maybe it worth to release 7.5.1?
> >> >>> It seems to be not good idea to stay on 7.4.0 due to CVE-2016-6806,
> >> >>> but broken websockets is also not an option :(
> >> >>> I would better have 7.5.1 rather than to add workaround, then remove
> >> >>> it as soon 7.6.0 will be released .....
> >> >>>
> >> >>> On Wed, Nov 2, 2016 at 10:16 AM, Maxim Solodovnik <
> >> solomax666@gmail.com>
> >> >>> wrote:
> >> >>> > Thanks Martin,
> >> >>> > will revert to 7.4.0
> >> >>> >
> >> >>> > On Wed, Nov 2, 2016 at 1:46 AM, Martin Grigorov <
> >> mgrigorov@apache.org>
> >> >>> > wrote:
> >> >>> >>
> >> >>> >> Hi Maxim,
> >> >>> >>
> >> >>> >> Yes, this is known and fixed for 7.6.0.
> >> >>> >> A workaround is explained here:
> >> >>> >> http://markmail.org/message/jyqosuuiyujl3ay6
> >> >>> >>
> >> >>> >> Martin Grigorov
> >> >>> >> Wicket Training and Consulting
> >> >>> >> https://twitter.com/mtgrigorov
> >> >>> >>
> >> >>> >> On Tue, Nov 1, 2016 at 5:07 PM, Maxim Solodovnik <
> >> solomax666@gmail.com>
> >> >>> >> wrote:
> >> >>> >>
> >> >>> >> > Hello Martin,
> >> >>> >> >
> >> >>> >> > WebSocketBehavior seems to be broken, I guess it is caused by
> [1]
> >> ,
> >> >>> but
> >> >>> >> > not
> >> >>> >> > sure
> >> >>> >> >
> >> >>> >> > here is quickstart: https://github.com/solomax/
> wicket-websocket
> >> >>> >> > The error differs depending on this line [2] commented or not
> >> >>> >> > This is blocker for our project :(
> >> >>> >> >
> >> >>> >> > sorry for reporting this after release, I was on vacation :(
> >> >>> >> >
> >> >>> >> >
> >> >>> >> > [1]
> >> >>> >> > https://github.com/apache/wicket/commit/
> >> >>> b6225514d9ad35a545750e2930485e
> >> >>> >> > 212e95ca88
> >> >>> >> > [2]
> >> >>> >> > https://github.com/solomax/wicket-websocket/blob/master/
> >> >>> >> > src/main/java/org/apache/solomax/WicketApplication.java#L39
> >> >>> >> >
> >> >>> >> > --
> >> >>> >> > WBR
> >> >>> >> > Maxim aka solomax
> >> >>> >> >
> >> >>> >
> >> >>> >
> >> >>> >
> >> >>> >
> >> >>> > --
> >> >>> > WBR
> >> >>> > Maxim aka solomax
> >> >>>
> >> >>>
> >> >>>
> >> >>> --
> >> >>> WBR
> >> >>> Maxim aka solomax
> >> >>>
> >> >
> >> >
> >> >
> >> > --
> >> > WBR
> >> > Maxim aka solomax
> >>
> >>
> >>
> >> --
> >> WBR
> >> Maxim aka solomax
> >>
>
>
>
> --
> Become a Wicket expert, learn from the best: http://wicketinaction.com
>

Re: Issue with WebSocketBehaviour in 7.5.0

Posted by Maxim Solodovnik <so...@gmail.com>.
Great news!
Thanks!

WBR, Maxim
(from mobile, sorry for the typos)

On Nov 11, 2016 22:34, "Martijn Dashorst" <ma...@gmail.com>
wrote:

> On Fri, Nov 11, 2016 at 7:46 AM, Martin Grigorov <mg...@apache.org>
> wrote:
> > I don't mind.
> > If Martijn has time to do it.
>
> Next week when my presentation is done :-).
>
> I've wanted to work with Andrea to make him a release manager as well.
> A 7.6 or 7.5.1 seems like a good start :-)
>
> Martijn
>
> >
> > Martin Grigorov
> > Wicket Training and Consulting
> > https://twitter.com/mtgrigorov
> >
> > On Thu, Nov 10, 2016 at 5:53 PM, Maxim Solodovnik <so...@gmail.com>
> > wrote:
> >
> >> 7.4.0 has this error:
> >> https://github.com/apache/wicket/commit/f4a6996aa4c3240b31ba191ef39686
> >> 4bf0dfad6c
> >> Maybe 7.5.1 is not that bad idea?
> >>
> >> On Tue, Nov 8, 2016 at 7:31 PM, Maxim Solodovnik <so...@gmail.com>
> >> wrote:
> >> > Good idea,
> >> > Thanks a lot! :)
> >> >
> >> > On Tue, Nov 8, 2016 at 7:30 PM, Martin Grigorov <mgrigorov@apache.org
> >
> >> wrote:
> >> >> You may use Wicket 7.5.0 + Wicket Native WebSocket 7.4.0
> >> >> They are binary compatible.
> >> >>
> >> >> Martin Grigorov
> >> >> Wicket Training and Consulting
> >> >> https://twitter.com/mtgrigorov
> >> >>
> >> >> On Tue, Nov 8, 2016 at 1:12 PM, Maxim Solodovnik <
> solomax666@gmail.com>
> >> >> wrote:
> >> >>
> >> >>> Maybe it worth to release 7.5.1?
> >> >>> It seems to be not good idea to stay on 7.4.0 due to CVE-2016-6806,
> >> >>> but broken websockets is also not an option :(
> >> >>> I would better have 7.5.1 rather than to add workaround, then remove
> >> >>> it as soon 7.6.0 will be released .....
> >> >>>
> >> >>> On Wed, Nov 2, 2016 at 10:16 AM, Maxim Solodovnik <
> >> solomax666@gmail.com>
> >> >>> wrote:
> >> >>> > Thanks Martin,
> >> >>> > will revert to 7.4.0
> >> >>> >
> >> >>> > On Wed, Nov 2, 2016 at 1:46 AM, Martin Grigorov <
> >> mgrigorov@apache.org>
> >> >>> > wrote:
> >> >>> >>
> >> >>> >> Hi Maxim,
> >> >>> >>
> >> >>> >> Yes, this is known and fixed for 7.6.0.
> >> >>> >> A workaround is explained here:
> >> >>> >> http://markmail.org/message/jyqosuuiyujl3ay6
> >> >>> >>
> >> >>> >> Martin Grigorov
> >> >>> >> Wicket Training and Consulting
> >> >>> >> https://twitter.com/mtgrigorov
> >> >>> >>
> >> >>> >> On Tue, Nov 1, 2016 at 5:07 PM, Maxim Solodovnik <
> >> solomax666@gmail.com>
> >> >>> >> wrote:
> >> >>> >>
> >> >>> >> > Hello Martin,
> >> >>> >> >
> >> >>> >> > WebSocketBehavior seems to be broken, I guess it is caused by
> [1]
> >> ,
> >> >>> but
> >> >>> >> > not
> >> >>> >> > sure
> >> >>> >> >
> >> >>> >> > here is quickstart: https://github.com/solomax/
> wicket-websocket
> >> >>> >> > The error differs depending on this line [2] commented or not
> >> >>> >> > This is blocker for our project :(
> >> >>> >> >
> >> >>> >> > sorry for reporting this after release, I was on vacation :(
> >> >>> >> >
> >> >>> >> >
> >> >>> >> > [1]
> >> >>> >> > https://github.com/apache/wicket/commit/
> >> >>> b6225514d9ad35a545750e2930485e
> >> >>> >> > 212e95ca88
> >> >>> >> > [2]
> >> >>> >> > https://github.com/solomax/wicket-websocket/blob/master/
> >> >>> >> > src/main/java/org/apache/solomax/WicketApplication.java#L39
> >> >>> >> >
> >> >>> >> > --
> >> >>> >> > WBR
> >> >>> >> > Maxim aka solomax
> >> >>> >> >
> >> >>> >
> >> >>> >
> >> >>> >
> >> >>> >
> >> >>> > --
> >> >>> > WBR
> >> >>> > Maxim aka solomax
> >> >>>
> >> >>>
> >> >>>
> >> >>> --
> >> >>> WBR
> >> >>> Maxim aka solomax
> >> >>>
> >> >
> >> >
> >> >
> >> > --
> >> > WBR
> >> > Maxim aka solomax
> >>
> >>
> >>
> >> --
> >> WBR
> >> Maxim aka solomax
> >>
>
>
>
> --
> Become a Wicket expert, learn from the best: http://wicketinaction.com
>

Re: Issue with WebSocketBehaviour in 7.5.0

Posted by Martijn Dashorst <ma...@gmail.com>.
On Fri, Nov 11, 2016 at 7:46 AM, Martin Grigorov <mg...@apache.org> wrote:
> I don't mind.
> If Martijn has time to do it.

Next week when my presentation is done :-).

I've wanted to work with Andrea to make him a release manager as well.
A 7.6 or 7.5.1 seems like a good start :-)

Martijn

>
> Martin Grigorov
> Wicket Training and Consulting
> https://twitter.com/mtgrigorov
>
> On Thu, Nov 10, 2016 at 5:53 PM, Maxim Solodovnik <so...@gmail.com>
> wrote:
>
>> 7.4.0 has this error:
>> https://github.com/apache/wicket/commit/f4a6996aa4c3240b31ba191ef39686
>> 4bf0dfad6c
>> Maybe 7.5.1 is not that bad idea?
>>
>> On Tue, Nov 8, 2016 at 7:31 PM, Maxim Solodovnik <so...@gmail.com>
>> wrote:
>> > Good idea,
>> > Thanks a lot! :)
>> >
>> > On Tue, Nov 8, 2016 at 7:30 PM, Martin Grigorov <mg...@apache.org>
>> wrote:
>> >> You may use Wicket 7.5.0 + Wicket Native WebSocket 7.4.0
>> >> They are binary compatible.
>> >>
>> >> Martin Grigorov
>> >> Wicket Training and Consulting
>> >> https://twitter.com/mtgrigorov
>> >>
>> >> On Tue, Nov 8, 2016 at 1:12 PM, Maxim Solodovnik <so...@gmail.com>
>> >> wrote:
>> >>
>> >>> Maybe it worth to release 7.5.1?
>> >>> It seems to be not good idea to stay on 7.4.0 due to CVE-2016-6806,
>> >>> but broken websockets is also not an option :(
>> >>> I would better have 7.5.1 rather than to add workaround, then remove
>> >>> it as soon 7.6.0 will be released .....
>> >>>
>> >>> On Wed, Nov 2, 2016 at 10:16 AM, Maxim Solodovnik <
>> solomax666@gmail.com>
>> >>> wrote:
>> >>> > Thanks Martin,
>> >>> > will revert to 7.4.0
>> >>> >
>> >>> > On Wed, Nov 2, 2016 at 1:46 AM, Martin Grigorov <
>> mgrigorov@apache.org>
>> >>> > wrote:
>> >>> >>
>> >>> >> Hi Maxim,
>> >>> >>
>> >>> >> Yes, this is known and fixed for 7.6.0.
>> >>> >> A workaround is explained here:
>> >>> >> http://markmail.org/message/jyqosuuiyujl3ay6
>> >>> >>
>> >>> >> Martin Grigorov
>> >>> >> Wicket Training and Consulting
>> >>> >> https://twitter.com/mtgrigorov
>> >>> >>
>> >>> >> On Tue, Nov 1, 2016 at 5:07 PM, Maxim Solodovnik <
>> solomax666@gmail.com>
>> >>> >> wrote:
>> >>> >>
>> >>> >> > Hello Martin,
>> >>> >> >
>> >>> >> > WebSocketBehavior seems to be broken, I guess it is caused by [1]
>> ,
>> >>> but
>> >>> >> > not
>> >>> >> > sure
>> >>> >> >
>> >>> >> > here is quickstart: https://github.com/solomax/wicket-websocket
>> >>> >> > The error differs depending on this line [2] commented or not
>> >>> >> > This is blocker for our project :(
>> >>> >> >
>> >>> >> > sorry for reporting this after release, I was on vacation :(
>> >>> >> >
>> >>> >> >
>> >>> >> > [1]
>> >>> >> > https://github.com/apache/wicket/commit/
>> >>> b6225514d9ad35a545750e2930485e
>> >>> >> > 212e95ca88
>> >>> >> > [2]
>> >>> >> > https://github.com/solomax/wicket-websocket/blob/master/
>> >>> >> > src/main/java/org/apache/solomax/WicketApplication.java#L39
>> >>> >> >
>> >>> >> > --
>> >>> >> > WBR
>> >>> >> > Maxim aka solomax
>> >>> >> >
>> >>> >
>> >>> >
>> >>> >
>> >>> >
>> >>> > --
>> >>> > WBR
>> >>> > Maxim aka solomax
>> >>>
>> >>>
>> >>>
>> >>> --
>> >>> WBR
>> >>> Maxim aka solomax
>> >>>
>> >
>> >
>> >
>> > --
>> > WBR
>> > Maxim aka solomax
>>
>>
>>
>> --
>> WBR
>> Maxim aka solomax
>>



-- 
Become a Wicket expert, learn from the best: http://wicketinaction.com

Re: Issue with WebSocketBehaviour in 7.5.0

Posted by Martin Grigorov <mg...@apache.org>.
I don't mind.
If Martijn has time to do it.

Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov

On Thu, Nov 10, 2016 at 5:53 PM, Maxim Solodovnik <so...@gmail.com>
wrote:

> 7.4.0 has this error:
> https://github.com/apache/wicket/commit/f4a6996aa4c3240b31ba191ef39686
> 4bf0dfad6c
> Maybe 7.5.1 is not that bad idea?
>
> On Tue, Nov 8, 2016 at 7:31 PM, Maxim Solodovnik <so...@gmail.com>
> wrote:
> > Good idea,
> > Thanks a lot! :)
> >
> > On Tue, Nov 8, 2016 at 7:30 PM, Martin Grigorov <mg...@apache.org>
> wrote:
> >> You may use Wicket 7.5.0 + Wicket Native WebSocket 7.4.0
> >> They are binary compatible.
> >>
> >> Martin Grigorov
> >> Wicket Training and Consulting
> >> https://twitter.com/mtgrigorov
> >>
> >> On Tue, Nov 8, 2016 at 1:12 PM, Maxim Solodovnik <so...@gmail.com>
> >> wrote:
> >>
> >>> Maybe it worth to release 7.5.1?
> >>> It seems to be not good idea to stay on 7.4.0 due to CVE-2016-6806,
> >>> but broken websockets is also not an option :(
> >>> I would better have 7.5.1 rather than to add workaround, then remove
> >>> it as soon 7.6.0 will be released .....
> >>>
> >>> On Wed, Nov 2, 2016 at 10:16 AM, Maxim Solodovnik <
> solomax666@gmail.com>
> >>> wrote:
> >>> > Thanks Martin,
> >>> > will revert to 7.4.0
> >>> >
> >>> > On Wed, Nov 2, 2016 at 1:46 AM, Martin Grigorov <
> mgrigorov@apache.org>
> >>> > wrote:
> >>> >>
> >>> >> Hi Maxim,
> >>> >>
> >>> >> Yes, this is known and fixed for 7.6.0.
> >>> >> A workaround is explained here:
> >>> >> http://markmail.org/message/jyqosuuiyujl3ay6
> >>> >>
> >>> >> Martin Grigorov
> >>> >> Wicket Training and Consulting
> >>> >> https://twitter.com/mtgrigorov
> >>> >>
> >>> >> On Tue, Nov 1, 2016 at 5:07 PM, Maxim Solodovnik <
> solomax666@gmail.com>
> >>> >> wrote:
> >>> >>
> >>> >> > Hello Martin,
> >>> >> >
> >>> >> > WebSocketBehavior seems to be broken, I guess it is caused by [1]
> ,
> >>> but
> >>> >> > not
> >>> >> > sure
> >>> >> >
> >>> >> > here is quickstart: https://github.com/solomax/wicket-websocket
> >>> >> > The error differs depending on this line [2] commented or not
> >>> >> > This is blocker for our project :(
> >>> >> >
> >>> >> > sorry for reporting this after release, I was on vacation :(
> >>> >> >
> >>> >> >
> >>> >> > [1]
> >>> >> > https://github.com/apache/wicket/commit/
> >>> b6225514d9ad35a545750e2930485e
> >>> >> > 212e95ca88
> >>> >> > [2]
> >>> >> > https://github.com/solomax/wicket-websocket/blob/master/
> >>> >> > src/main/java/org/apache/solomax/WicketApplication.java#L39
> >>> >> >
> >>> >> > --
> >>> >> > WBR
> >>> >> > Maxim aka solomax
> >>> >> >
> >>> >
> >>> >
> >>> >
> >>> >
> >>> > --
> >>> > WBR
> >>> > Maxim aka solomax
> >>>
> >>>
> >>>
> >>> --
> >>> WBR
> >>> Maxim aka solomax
> >>>
> >
> >
> >
> > --
> > WBR
> > Maxim aka solomax
>
>
>
> --
> WBR
> Maxim aka solomax
>

Re: Issue with WebSocketBehaviour in 7.5.0

Posted by Maxim Solodovnik <so...@gmail.com>.
7.4.0 has this error:
https://github.com/apache/wicket/commit/f4a6996aa4c3240b31ba191ef396864bf0dfad6c
Maybe 7.5.1 is not that bad idea?

On Tue, Nov 8, 2016 at 7:31 PM, Maxim Solodovnik <so...@gmail.com> wrote:
> Good idea,
> Thanks a lot! :)
>
> On Tue, Nov 8, 2016 at 7:30 PM, Martin Grigorov <mg...@apache.org> wrote:
>> You may use Wicket 7.5.0 + Wicket Native WebSocket 7.4.0
>> They are binary compatible.
>>
>> Martin Grigorov
>> Wicket Training and Consulting
>> https://twitter.com/mtgrigorov
>>
>> On Tue, Nov 8, 2016 at 1:12 PM, Maxim Solodovnik <so...@gmail.com>
>> wrote:
>>
>>> Maybe it worth to release 7.5.1?
>>> It seems to be not good idea to stay on 7.4.0 due to CVE-2016-6806,
>>> but broken websockets is also not an option :(
>>> I would better have 7.5.1 rather than to add workaround, then remove
>>> it as soon 7.6.0 will be released .....
>>>
>>> On Wed, Nov 2, 2016 at 10:16 AM, Maxim Solodovnik <so...@gmail.com>
>>> wrote:
>>> > Thanks Martin,
>>> > will revert to 7.4.0
>>> >
>>> > On Wed, Nov 2, 2016 at 1:46 AM, Martin Grigorov <mg...@apache.org>
>>> > wrote:
>>> >>
>>> >> Hi Maxim,
>>> >>
>>> >> Yes, this is known and fixed for 7.6.0.
>>> >> A workaround is explained here:
>>> >> http://markmail.org/message/jyqosuuiyujl3ay6
>>> >>
>>> >> Martin Grigorov
>>> >> Wicket Training and Consulting
>>> >> https://twitter.com/mtgrigorov
>>> >>
>>> >> On Tue, Nov 1, 2016 at 5:07 PM, Maxim Solodovnik <so...@gmail.com>
>>> >> wrote:
>>> >>
>>> >> > Hello Martin,
>>> >> >
>>> >> > WebSocketBehavior seems to be broken, I guess it is caused by [1] ,
>>> but
>>> >> > not
>>> >> > sure
>>> >> >
>>> >> > here is quickstart: https://github.com/solomax/wicket-websocket
>>> >> > The error differs depending on this line [2] commented or not
>>> >> > This is blocker for our project :(
>>> >> >
>>> >> > sorry for reporting this after release, I was on vacation :(
>>> >> >
>>> >> >
>>> >> > [1]
>>> >> > https://github.com/apache/wicket/commit/
>>> b6225514d9ad35a545750e2930485e
>>> >> > 212e95ca88
>>> >> > [2]
>>> >> > https://github.com/solomax/wicket-websocket/blob/master/
>>> >> > src/main/java/org/apache/solomax/WicketApplication.java#L39
>>> >> >
>>> >> > --
>>> >> > WBR
>>> >> > Maxim aka solomax
>>> >> >
>>> >
>>> >
>>> >
>>> >
>>> > --
>>> > WBR
>>> > Maxim aka solomax
>>>
>>>
>>>
>>> --
>>> WBR
>>> Maxim aka solomax
>>>
>
>
>
> --
> WBR
> Maxim aka solomax



-- 
WBR
Maxim aka solomax

Re: Issue with WebSocketBehaviour in 7.5.0

Posted by Maxim Solodovnik <so...@gmail.com>.
Good idea,
Thanks a lot! :)

On Tue, Nov 8, 2016 at 7:30 PM, Martin Grigorov <mg...@apache.org> wrote:
> You may use Wicket 7.5.0 + Wicket Native WebSocket 7.4.0
> They are binary compatible.
>
> Martin Grigorov
> Wicket Training and Consulting
> https://twitter.com/mtgrigorov
>
> On Tue, Nov 8, 2016 at 1:12 PM, Maxim Solodovnik <so...@gmail.com>
> wrote:
>
>> Maybe it worth to release 7.5.1?
>> It seems to be not good idea to stay on 7.4.0 due to CVE-2016-6806,
>> but broken websockets is also not an option :(
>> I would better have 7.5.1 rather than to add workaround, then remove
>> it as soon 7.6.0 will be released .....
>>
>> On Wed, Nov 2, 2016 at 10:16 AM, Maxim Solodovnik <so...@gmail.com>
>> wrote:
>> > Thanks Martin,
>> > will revert to 7.4.0
>> >
>> > On Wed, Nov 2, 2016 at 1:46 AM, Martin Grigorov <mg...@apache.org>
>> > wrote:
>> >>
>> >> Hi Maxim,
>> >>
>> >> Yes, this is known and fixed for 7.6.0.
>> >> A workaround is explained here:
>> >> http://markmail.org/message/jyqosuuiyujl3ay6
>> >>
>> >> Martin Grigorov
>> >> Wicket Training and Consulting
>> >> https://twitter.com/mtgrigorov
>> >>
>> >> On Tue, Nov 1, 2016 at 5:07 PM, Maxim Solodovnik <so...@gmail.com>
>> >> wrote:
>> >>
>> >> > Hello Martin,
>> >> >
>> >> > WebSocketBehavior seems to be broken, I guess it is caused by [1] ,
>> but
>> >> > not
>> >> > sure
>> >> >
>> >> > here is quickstart: https://github.com/solomax/wicket-websocket
>> >> > The error differs depending on this line [2] commented or not
>> >> > This is blocker for our project :(
>> >> >
>> >> > sorry for reporting this after release, I was on vacation :(
>> >> >
>> >> >
>> >> > [1]
>> >> > https://github.com/apache/wicket/commit/
>> b6225514d9ad35a545750e2930485e
>> >> > 212e95ca88
>> >> > [2]
>> >> > https://github.com/solomax/wicket-websocket/blob/master/
>> >> > src/main/java/org/apache/solomax/WicketApplication.java#L39
>> >> >
>> >> > --
>> >> > WBR
>> >> > Maxim aka solomax
>> >> >
>> >
>> >
>> >
>> >
>> > --
>> > WBR
>> > Maxim aka solomax
>>
>>
>>
>> --
>> WBR
>> Maxim aka solomax
>>



-- 
WBR
Maxim aka solomax

Re: Issue with WebSocketBehaviour in 7.5.0

Posted by Martin Grigorov <mg...@apache.org>.
You may use Wicket 7.5.0 + Wicket Native WebSocket 7.4.0
They are binary compatible.

Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov

On Tue, Nov 8, 2016 at 1:12 PM, Maxim Solodovnik <so...@gmail.com>
wrote:

> Maybe it worth to release 7.5.1?
> It seems to be not good idea to stay on 7.4.0 due to CVE-2016-6806,
> but broken websockets is also not an option :(
> I would better have 7.5.1 rather than to add workaround, then remove
> it as soon 7.6.0 will be released .....
>
> On Wed, Nov 2, 2016 at 10:16 AM, Maxim Solodovnik <so...@gmail.com>
> wrote:
> > Thanks Martin,
> > will revert to 7.4.0
> >
> > On Wed, Nov 2, 2016 at 1:46 AM, Martin Grigorov <mg...@apache.org>
> > wrote:
> >>
> >> Hi Maxim,
> >>
> >> Yes, this is known and fixed for 7.6.0.
> >> A workaround is explained here:
> >> http://markmail.org/message/jyqosuuiyujl3ay6
> >>
> >> Martin Grigorov
> >> Wicket Training and Consulting
> >> https://twitter.com/mtgrigorov
> >>
> >> On Tue, Nov 1, 2016 at 5:07 PM, Maxim Solodovnik <so...@gmail.com>
> >> wrote:
> >>
> >> > Hello Martin,
> >> >
> >> > WebSocketBehavior seems to be broken, I guess it is caused by [1] ,
> but
> >> > not
> >> > sure
> >> >
> >> > here is quickstart: https://github.com/solomax/wicket-websocket
> >> > The error differs depending on this line [2] commented or not
> >> > This is blocker for our project :(
> >> >
> >> > sorry for reporting this after release, I was on vacation :(
> >> >
> >> >
> >> > [1]
> >> > https://github.com/apache/wicket/commit/
> b6225514d9ad35a545750e2930485e
> >> > 212e95ca88
> >> > [2]
> >> > https://github.com/solomax/wicket-websocket/blob/master/
> >> > src/main/java/org/apache/solomax/WicketApplication.java#L39
> >> >
> >> > --
> >> > WBR
> >> > Maxim aka solomax
> >> >
> >
> >
> >
> >
> > --
> > WBR
> > Maxim aka solomax
>
>
>
> --
> WBR
> Maxim aka solomax
>

Re: Issue with WebSocketBehaviour in 7.5.0

Posted by Maxim Solodovnik <so...@gmail.com>.
Maybe it worth to release 7.5.1?
It seems to be not good idea to stay on 7.4.0 due to CVE-2016-6806,
but broken websockets is also not an option :(
I would better have 7.5.1 rather than to add workaround, then remove
it as soon 7.6.0 will be released .....

On Wed, Nov 2, 2016 at 10:16 AM, Maxim Solodovnik <so...@gmail.com> wrote:
> Thanks Martin,
> will revert to 7.4.0
>
> On Wed, Nov 2, 2016 at 1:46 AM, Martin Grigorov <mg...@apache.org>
> wrote:
>>
>> Hi Maxim,
>>
>> Yes, this is known and fixed for 7.6.0.
>> A workaround is explained here:
>> http://markmail.org/message/jyqosuuiyujl3ay6
>>
>> Martin Grigorov
>> Wicket Training and Consulting
>> https://twitter.com/mtgrigorov
>>
>> On Tue, Nov 1, 2016 at 5:07 PM, Maxim Solodovnik <so...@gmail.com>
>> wrote:
>>
>> > Hello Martin,
>> >
>> > WebSocketBehavior seems to be broken, I guess it is caused by [1] , but
>> > not
>> > sure
>> >
>> > here is quickstart: https://github.com/solomax/wicket-websocket
>> > The error differs depending on this line [2] commented or not
>> > This is blocker for our project :(
>> >
>> > sorry for reporting this after release, I was on vacation :(
>> >
>> >
>> > [1]
>> > https://github.com/apache/wicket/commit/b6225514d9ad35a545750e2930485e
>> > 212e95ca88
>> > [2]
>> > https://github.com/solomax/wicket-websocket/blob/master/
>> > src/main/java/org/apache/solomax/WicketApplication.java#L39
>> >
>> > --
>> > WBR
>> > Maxim aka solomax
>> >
>
>
>
>
> --
> WBR
> Maxim aka solomax



-- 
WBR
Maxim aka solomax

Re: Issue with WebSocketBehaviour in 7.5.0

Posted by Maxim Solodovnik <so...@gmail.com>.
Thanks Martin,
will revert to 7.4.0

On Wed, Nov 2, 2016 at 1:46 AM, Martin Grigorov <mg...@apache.org>
wrote:

> Hi Maxim,
>
> Yes, this is known and fixed for 7.6.0.
> A workaround is explained here: http://markmail.org/message/
> jyqosuuiyujl3ay6
>
> Martin Grigorov
> Wicket Training and Consulting
> https://twitter.com/mtgrigorov
>
> On Tue, Nov 1, 2016 at 5:07 PM, Maxim Solodovnik <so...@gmail.com>
> wrote:
>
> > Hello Martin,
> >
> > WebSocketBehavior seems to be broken, I guess it is caused by [1] , but
> not
> > sure
> >
> > here is quickstart: https://github.com/solomax/wicket-websocket
> > The error differs depending on this line [2] commented or not
> > This is blocker for our project :(
> >
> > sorry for reporting this after release, I was on vacation :(
> >
> >
> > [1]
> > https://github.com/apache/wicket/commit/b6225514d9ad35a545750e2930485e
> > 212e95ca88
> > [2]
> > https://github.com/solomax/wicket-websocket/blob/master/
> > src/main/java/org/apache/solomax/WicketApplication.java#L39
> >
> > --
> > WBR
> > Maxim aka solomax
> >
>



-- 
WBR
Maxim aka solomax

Re: Issue with WebSocketBehaviour in 7.5.0

Posted by Martin Grigorov <mg...@apache.org>.
Hi Maxim,

Yes, this is known and fixed for 7.6.0.
A workaround is explained here: http://markmail.org/message/jyqosuuiyujl3ay6

Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov

On Tue, Nov 1, 2016 at 5:07 PM, Maxim Solodovnik <so...@gmail.com>
wrote:

> Hello Martin,
>
> WebSocketBehavior seems to be broken, I guess it is caused by [1] , but not
> sure
>
> here is quickstart: https://github.com/solomax/wicket-websocket
> The error differs depending on this line [2] commented or not
> This is blocker for our project :(
>
> sorry for reporting this after release, I was on vacation :(
>
>
> [1]
> https://github.com/apache/wicket/commit/b6225514d9ad35a545750e2930485e
> 212e95ca88
> [2]
> https://github.com/solomax/wicket-websocket/blob/master/
> src/main/java/org/apache/solomax/WicketApplication.java#L39
>
> --
> WBR
> Maxim aka solomax
>