[GitHub] [doris] morrySnow commented on a diff in pull request #21125: [fix](nereids)change PushdownFilterThroughProject post processor from bottom up to top down rewrite

["morrySnow (via GitHub)" <gi...@apache.org>]

morrySnow commented on code in PR #21125:
URL: https://github.com/apache/doris/pull/21125#discussion_r1241124491


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/processor/post/PushdownFilterThroughProject.java:
##########
@@ -30,17 +30,18 @@ public class PushdownFilterThroughProject extends PlanPostProcessor {
     @Override
     public Plan visitPhysicalFilter(PhysicalFilter<? extends Plan> filter, CascadesContext context) {
         Plan child = filter.child();
-        Plan newChild = child.accept(this, context);
-        if (!(newChild instanceof PhysicalProject)) {
+        if (!(child instanceof PhysicalProject)) {
             return filter;

Review Comment:
   ```suggestion
              return filter.withChildren(child.accept(this, context));
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org