[I] cli: fix small gaps in existing commands [iggy]

["hubcio (via GitHub)" <gi...@apache.org>]

hubcio opened a new issue, #4450:
URL: https://github.com/apache/iggy/issues/4450

   ## Problem and proposal
   
   Each item is a small, separate change.
   
   - [ ] `topic get` (`core/cli/src/commands/binary_topics/get_topic.rs:69`) ignores `partitions` and `options` in `TopicDetails` (`core/common/src/types/topic/mod.rs:97`, `:101`). After `topic create --durability persisted`, no CLI command shows the durability. Print a partitions table and one row per `options` key.
   - [ ] `user permissions` replaces the full permission set. For example, `user permissions u -g p_msg` removes all other global and stream permissions of `u`. Add `user grant` and `user revoke`, which read the current set, change it, and send it back.
   - [ ] The `-g` and `-s` help of `user permissions` is a copy from `user create`. It says "for created user", and its examples run `iggy user create` (`core/cli/src/args/user.rs:252-303`).
   - [ ] `stream create -s` and `topic create -t` are ignored. The help says so, but its examples still use them, and the CLI prints no warning. Remove both flags, and print the ID that the server assigns.
   - [ ] `consumer-offset set` always says "consumer" (`core/cli/src/commands/binary_consumer_offsets/set_consumer_offset.rs:60`, `:71`, `:77`), also for `consumer-group` and `external-group`. Reuse `get_consumer_info` (`core/cli/src/commands/binary_consumer_offsets/get_consumer_offset.rs:52`).
   - [ ] `topic update` requires the compression argument and always sends it (`core/cli/src/args/topic.rs:169`), so every update also sets the compression. Expiry and `-m` are already optional. Make compression and expiry optional flags in the same release. If only compression moves, an old `... NAME none` call parses `none` as the expiry.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] cli: fix small gaps in existing commands [iggy]

["justinmclean (via GitHub)" <gi...@apache.org>]

justinmclean commented on issue #4450:
URL: https://github.com/apache/iggy/issues/4450#issuecomment-6060878992

   Split the three small items into their own good first issues so different newcomers can take them: the `user permissions` help text, the `consumer-offset set` wording, and the `topic get` partitions and options output. The rest (`user grant` and `user revoke`, removing `stream create -s` and `topic create -t`, and the `topic update` arguments) needs decisions first, so I removed the good first issue label here.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org