[GitHub] [pulsar] aloyszhang commented on a change in pull request #14488: refactor ManagedLedger cacheEvictionTask implement

[GitBox <gi...@apache.org>]

aloyszhang commented on a change in pull request #14488:
URL: https://github.com/apache/pulsar/pull/14488#discussion_r815751961



##########
File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -1685,7 +1685,14 @@
     private double managedLedgerCacheEvictionWatermark = 0.9;
     @FieldContext(category = CATEGORY_STORAGE_ML,
             doc = "Configure the cache eviction frequency for the managed ledger cache. Default is 100/s")
+    @Deprecated
     private double managedLedgerCacheEvictionFrequency = 100.0;
+
+    @FieldContext(category = CATEGORY_STORAGE_ML,
+            doc = "Configure the cache eviction interval for the managed ledger cache. Must >= 1 ms, "
+                    + " and default is 10 ms")
+    private long managedLedgerCacheEvictionIntervalMs = 10;
+

Review comment:
       You're right, I'll add compatible logic here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org