[GitHub] [incubator-shardingsphere] liuyangming commented on issue #2951: fix issue 2902: Fix bugs in support for spring declarative transactions

[GitBox <gi...@apache.org>]

liuyangming commented on issue #2951: fix issue 2902: Fix bugs in support for spring declarative transactions
URL: https://github.com/apache/incubator-shardingsphere/pull/2951#issuecomment-526540074
 
 
   > @liuyangming thanks for your contribution.
   > when I see your example [RequiresNewOrderServiceImpl.java](https://github.com/liuyangming/shardingjdbc-sample/blob/issue-2902/src/main/java/com/bytesvc/shardingjdbc/sample/service/impl/RequiresNewOrderServiceImpl.java), I want to clarify our current transaction scope.
   > 
   > 1.support distribute transaction in one ShardingConnection.
   > 2.support distribute transaction using local transaction api.
   > 3.not support distribute transaction in multiple sharding connections.
   > 4.not support distribute transaction in JTA way.
   > 
   > it seems that you're trying to do some work on `4.` point, in my opinion, the example code can be only supported by JTA, but this is not what we want to integrate currently.
   
   This is a standard usage scenario, regardless of whether or not JTA is used. There is unnecessary to require the business system to abandon the spring declarative transaction. Although such a constraint can be made, in general it is not reasonable. sharding-jdbc should consider this requirement as much as possible.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services