You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2026/06/04 16:05:50 UTC

[PR] ci: drop removed Cypress shards from required status checks [superset]

rusackas opened a new pull request, #40770:
URL: https://github.com/apache/superset/pull/40770

   ### SUMMARY
   
   **This unblocks PR merges.** #40717 reduced the Cypress matrix from **6 shards to
   2** (`parallel_id: [0, 1]`), but `.asf.yaml` still lists the old shards as
   **required status checks**:
   
   ```yaml
   required_status_checks:
     contexts:
       - cypress-matrix (0, chrome)
       - cypress-matrix (1, chrome)
       - cypress-matrix (2, chrome)   # ← no longer produced
       - cypress-matrix (3, chrome)   # ← no longer produced
       - cypress-matrix (4, chrome)   # ← no longer produced
       - cypress-matrix (5, chrome)   # ← no longer produced
   ```
   
   Since jobs `cypress-matrix (2..5, chrome)` no longer exist, those checks never
   report, so every PR is stuck on **"Expected — Waiting for status to be
   reported"** and can't merge. This removes the four obsolete contexts and keeps
   the two shards that actually run.
   
   I audited the rest of the `contexts:` list against the current workflows —
   everything else (`lint-check`, `frontend-build`, `playwright-tests (chromium)`,
   `pre-commit (current/previous)`, `test-mysql/postgres/sqlite/hive/presto`,
   `unit-tests (current)`, `dependency-review`) still maps to a live job, so this
   is the only stale entry.
   
   > ⚠️ **Merging this PR:** because the phantom `cypress-matrix (2..5)` contexts
   > are *currently* required, this PR itself will show them as "waiting" and the
   > normal merge button will be blocked. A committer/admin will need to merge it
   > (admin override), after which INFRA re-applies branch protection from
   > `.asf.yaml` and all other PRs unblock.
   
   > 📝 **Follow-up:** when #40722 (Python matrix → current-only on PRs) merges, it
   > will stop producing `pre-commit (previous)` on PRs, so that context will need
   > removing here too. Left in place for now since it currently runs.
   
   ### TESTING INSTRUCTIONS
   
   After this merges, confirm open PRs no longer show "Waiting for status" on the
   removed Cypress contexts and can merge with the 2-shard matrix.
   
   ### ADDITIONAL INFORMATION
   
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] ci: drop removed Cypress shards from required status checks [superset]

Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on PR #40770:
URL: https://github.com/apache/superset/pull/40770#issuecomment-4624023598

   I approved for quick unblocker for other folks but [Dependabot PRs on frontend](https://github.com/apache/superset/pull/40762) is still barred from merging. Can be done in another follow-up PR
   
   <img width="800" height="71" alt="image" src="https://github.com/user-attachments/assets/294bec0d-6189-42f4-a199-1c5f8ca4f994" />
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] ci: drop removed Cypress shards from required status checks [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #40770:
URL: https://github.com/apache/superset/pull/40770#issuecomment-4624066308

   @hainenber Checking it out... if you know what it is that needs to be changed, feel free to pile it on here, I'm seeking an admin merge from ASF, and would rather only ask the favor once :D 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] ci: drop removed Cypress shards from required status checks [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #40770:
URL: https://github.com/apache/superset/pull/40770#issuecomment-4624186175

   @hainenber https://github.com/apache/superset/pull/40772 should get those ones you caught.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] ci: drop removed Cypress shards from required status checks [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #40770:
URL: https://github.com/apache/superset/pull/40770#issuecomment-4623954604

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] ci: drop removed Cypress shards from required status checks [superset]

Posted by "Humbedooh (via GitHub)" <gi...@apache.org>.
Humbedooh merged PR #40770:
URL: https://github.com/apache/superset/pull/40770


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org