You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Jason Altekruse <al...@gmail.com> on 2014/12/20 00:40:34 UTC
Re: Review Request 29278: Drill-1904 package level docs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29278/
-----------------------------------------------------------
(Updated Dec. 19, 2014, 11:40 p.m.)
Review request for drill, Daniel Barclay and Jacques Nadeau.
Changes
-------
typo
Summary (updated)
-----------------
Drill-1904 package level docs
Bugs: Drill-1904
https://issues.apache.org/jira/browse/Drill-1904
Repository: drill-git
Description
-------
Add package level documentation to the sources of Drill
Diffs
-----
common/src/main/java/org/apache/drill/common/config/package-info.java PRE-CREATION
common/src/main/java/org/apache/drill/common/exceptions/package-info.java PRE-CREATION
common/src/main/java/org/apache/drill/common/expression/aggregate/BasicAggregates.java 5f18aaf
common/src/main/java/org/apache/drill/common/expression/fn/package-info.java PRE-CREATION
common/src/main/java/org/apache/drill/common/expression/package-info.java PRE-CREATION
common/src/main/java/org/apache/drill/common/expression/types/package-info.java PRE-CREATION
common/src/main/java/org/apache/drill/common/expression/visitors/package-info.java PRE-CREATION
common/src/main/java/org/apache/drill/common/graph/package-info.java PRE-CREATION
common/src/main/java/org/apache/drill/common/logical/FormatPluginConfig.java 936e4f2
common/src/main/java/org/apache/drill/common/logical/FormatPluginConfigBase.java 0704085
common/src/main/java/org/apache/drill/common/logical/data/package-info.java PRE-CREATION
common/src/main/java/org/apache/drill/common/logical/data/visitors/package-info.java PRE-CREATION
common/src/main/java/org/apache/drill/common/logical/package-info.java PRE-CREATION
common/src/main/java/org/apache/drill/common/package-info.java PRE-CREATION
common/src/main/java/org/apache/drill/common/types/package-info.java PRE-CREATION
common/src/main/java/org/apache/drill/common/util/package-info.java PRE-CREATION
contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/package-info.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/cache/package-info.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/client/package-info.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/compile/bytecode/package-info.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/compile/package-info.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/compile/sig/package-info.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/coord/local/package-info.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/coord/package-info.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/package-info.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/disk/package-info.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/dotdrill/package-info.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/exception/package-info.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/package-info.java PRE-CREATION
Diff: https://reviews.apache.org/r/29278/diff/
Testing
-------
Just comments, no code changes
Thanks,
Jason Altekruse
Re: Review Request 29278: Drill-1904 package level docs
Posted by Jason Altekruse <al...@gmail.com>.
> On Jan. 16, 2015, 11:23 p.m., Ted Dunning wrote:
> > common/src/main/java/org/apache/drill/common/config/package-info.java, line 21
> > <https://reviews.apache.org/r/29278/diff/3/?file=823063#file823063line21>
> >
> > Is nesting the salient character for this package? Is there anything else that would be surprising?
Added some more information about how config files are persisted and a referral to the class responsible for finding the files on the classpath/resolving configuration precedence.
> On Jan. 16, 2015, 11:23 p.m., Ted Dunning wrote:
> > common/src/main/java/org/apache/drill/common/exceptions/package-info.java, line 19
> > <https://reviews.apache.org/r/29278/diff/3/?file=823064#file823064line19>
> >
> > Probably not even needed. The name and the content speak for themselves.
> >
> > They may be something that is not said by these contents, but the mere fact that these are exceptions is, so to say, unexceptional.
Fair enough, for consistency I just documented it.
> On Jan. 16, 2015, 11:23 p.m., Ted Dunning wrote:
> > common/src/main/java/org/apache/drill/common/expression/package-info.java, line 19
> > <https://reviews.apache.org/r/29278/diff/3/?file=823067#file823067line19>
> >
> > Too thin to say anything here. What is a logical expression? An expression with nothing but booleans? Or an expression in the logical plan.
> >
> > Perhaps clarification by amplification is in order.
added additional clarification
> On Jan. 16, 2015, 11:23 p.m., Ted Dunning wrote:
> > common/src/main/java/org/apache/drill/common/expression/visitors/package-info.java, line 19
> > <https://reviews.apache.org/r/29278/diff/3/?file=823069#file823069line19>
> >
> > Used in what context? Who calls these? When are the inserted?
Added some information about where the visitors are used.
> On Jan. 16, 2015, 11:23 p.m., Ted Dunning wrote:
> > common/src/main/java/org/apache/drill/common/logical/FormatPluginConfig.java, line 27
> > <https://reviews.apache.org/r/29278/diff/3/?file=823071#file823071line27>
> >
> > Suggest "Formats are file formats that have nothing to do with how the file is stored, such as CSV or protobuf.
Updated comments to clarify the relationship between format plugins and storage plugins.
> On Jan. 16, 2015, 11:23 p.m., Ted Dunning wrote:
> > common/src/main/java/org/apache/drill/common/logical/FormatPluginConfigBase.java, line 27
> > <https://reviews.apache.org/r/29278/diff/3/?file=823072#file823072line27>
> >
> > A tiny bit more would be nice. "To use this base class, sub-class it and define .... Watch out fo r ..."
This actually isn't being used as the base class for anything. Opened a JIRA to review the current structure and removed the docs for now.
https://issues.apache.org/jira/browse/DRILL-2076
> On Jan. 16, 2015, 11:23 p.m., Ted Dunning wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/coord/package-info.java, line 19
> > <https://reviews.apache.org/r/29278/diff/3/?file=823086#file823086line19>
> >
> > Need a bit more here. Could have a pointer to what sort of coordination is done and a description of why.
> >
> > Is Curator used?
Added curator to the comment. I don't really think we maintain much beside cluster membership using zookeeper. I think this is a reasonable descritpion for now.
> On Jan. 16, 2015, 11:23 p.m., Ted Dunning wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/package-info.java, line 22
> > <https://reviews.apache.org/r/29278/diff/3/?file=823091#file823091line22>
> >
> > This is a top-level description that should not quote so much as redirect the reader. A link to the architecture home page is sufficient for that. Links to the key pieces of code to read next would be very helpful as well.
I have fixed the comment to include a link.
I started writing a more complete intro for new developers, but it was getting a bit long without covering the breadth I wanted. I have opened a JIRA for better starting documentation for new developers here as well as on the Wiki. I would like to get this patch in sooner to encourge others to write docs with a consistent style and format, but I will be trying to fit in an improvement to this documentation soon.
https://issues.apache.org/jira/browse/DRILL-2077
- Jason
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29278/#review68501
-----------------------------------------------------------
On Jan. 27, 2015, 1:36 a.m., Jason Altekruse wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29278/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2015, 1:36 a.m.)
>
>
> Review request for drill, Daniel Barclay and Jacques Nadeau.
>
>
> Bugs: Drill-1904
> https://issues.apache.org/jira/browse/Drill-1904
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Add package level documentation to the sources of Drill
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/drill/common/config/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/exceptions/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/expression/aggregate/BasicAggregates.java 5f18aaf
> common/src/main/java/org/apache/drill/common/expression/fn/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/expression/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/expression/types/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/expression/visitors/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/graph/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/logical/FormatPluginConfig.java 936e4f2
> common/src/main/java/org/apache/drill/common/logical/FormatPluginConfigBase.java 0704085
> common/src/main/java/org/apache/drill/common/logical/data/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/logical/data/visitors/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/logical/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/types/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/util/package-info.java PRE-CREATION
> contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/cache/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/client/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/compile/bytecode/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/compile/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/compile/sig/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/coord/local/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/coord/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/disk/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/dotdrill/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/exception/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/package-info.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29278/diff/
>
>
> Testing
> -------
>
> Just comments, no code changes
>
>
> Thanks,
>
> Jason Altekruse
>
>
Re: Review Request 29278: Drill-1904 package level docs
Posted by Ted Dunning <td...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29278/#review68501
-----------------------------------------------------------
common/src/main/java/org/apache/drill/common/config/package-info.java
<https://reviews.apache.org/r/29278/#comment112768>
Is nesting the salient character for this package? Is there anything else that would be surprising?
common/src/main/java/org/apache/drill/common/exceptions/package-info.java
<https://reviews.apache.org/r/29278/#comment112770>
Probably not even needed. The name and the content speak for themselves.
They may be something that is not said by these contents, but the mere fact that these are exceptions is, so to say, unexceptional.
common/src/main/java/org/apache/drill/common/expression/package-info.java
<https://reviews.apache.org/r/29278/#comment112771>
Too thin to say anything here. What is a logical expression? An expression with nothing but booleans? Or an expression in the logical plan.
Perhaps clarification by amplification is in order.
common/src/main/java/org/apache/drill/common/expression/visitors/package-info.java
<https://reviews.apache.org/r/29278/#comment112772>
Used in what context? Who calls these? When are the inserted?
common/src/main/java/org/apache/drill/common/logical/FormatPluginConfig.java
<https://reviews.apache.org/r/29278/#comment112773>
Suggest "Formats are file formats that have nothing to do with how the file is stored, such as CSV or protobuf.
common/src/main/java/org/apache/drill/common/logical/FormatPluginConfigBase.java
<https://reviews.apache.org/r/29278/#comment112776>
A tiny bit more would be nice. "To use this base class, sub-class it and define .... Watch out fo r ..."
exec/java-exec/src/main/java/org/apache/drill/exec/coord/package-info.java
<https://reviews.apache.org/r/29278/#comment112785>
Need a bit more here. Could have a pointer to what sort of coordination is done and a description of why.
Is Curator used?
exec/java-exec/src/main/java/org/apache/drill/exec/package-info.java
<https://reviews.apache.org/r/29278/#comment112780>
This is a top-level description that should not quote so much as redirect the reader. A link to the architecture home page is sufficient for that. Links to the key pieces of code to read next would be very helpful as well.
- Ted Dunning
On Jan. 15, 2015, 10:16 p.m., Jason Altekruse wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29278/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2015, 10:16 p.m.)
>
>
> Review request for drill, Daniel Barclay and Jacques Nadeau.
>
>
> Bugs: Drill-1904
> https://issues.apache.org/jira/browse/Drill-1904
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Add package level documentation to the sources of Drill
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/drill/common/config/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/exceptions/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/expression/aggregate/BasicAggregates.java 5f18aaf
> common/src/main/java/org/apache/drill/common/expression/fn/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/expression/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/expression/types/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/expression/visitors/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/graph/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/logical/FormatPluginConfig.java 936e4f2
> common/src/main/java/org/apache/drill/common/logical/FormatPluginConfigBase.java 0704085
> common/src/main/java/org/apache/drill/common/logical/data/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/logical/data/visitors/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/logical/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/types/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/util/package-info.java PRE-CREATION
> contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/cache/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/client/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/compile/bytecode/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/compile/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/compile/sig/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/coord/local/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/coord/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/disk/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/dotdrill/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/exception/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/package-info.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29278/diff/
>
>
> Testing
> -------
>
> Just comments, no code changes
>
>
> Thanks,
>
> Jason Altekruse
>
>
Re: Review Request 29278: Drill-1904 package level docs
Posted by Jason Altekruse <al...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29278/#review69693
-----------------------------------------------------------
common/src/main/java/org/apache/drill/common/config/package-info.java
<https://reviews.apache.org/r/29278/#comment114472>
Added some more information about how config files are persisted and a referral to the class responsible for finding the files on the classpath/resolving configuration precedence.
common/src/main/java/org/apache/drill/common/exceptions/package-info.java
<https://reviews.apache.org/r/29278/#comment114414>
Fair enough, for consistency I just documented it.
common/src/main/java/org/apache/drill/common/exceptions/package-info.java
<https://reviews.apache.org/r/29278/#comment114473>
I just wanted ot be consistent and have everything documented.
common/src/main/java/org/apache/drill/common/expression/package-info.java
<https://reviews.apache.org/r/29278/#comment114415>
added additional clarification
common/src/main/java/org/apache/drill/common/expression/package-info.java
<https://reviews.apache.org/r/29278/#comment114416>
added additional clarificaion
common/src/main/java/org/apache/drill/common/expression/visitors/package-info.java
<https://reviews.apache.org/r/29278/#comment114422>
Added some information about where the visitors are used.
common/src/main/java/org/apache/drill/common/logical/FormatPluginConfig.java
<https://reviews.apache.org/r/29278/#comment114424>
Updated comments to clarify the relationship between format plugins and storage plugins.
common/src/main/java/org/apache/drill/common/logical/FormatPluginConfigBase.java
<https://reviews.apache.org/r/29278/#comment114426>
This actually isn't being used as the base class for anything. Opened a JIRA to review the current structure and removed the docs for now.
https://issues.apache.org/jira/browse/DRILL-2076
exec/java-exec/src/main/java/org/apache/drill/exec/coord/package-info.java
<https://reviews.apache.org/r/29278/#comment114463>
Added curator to the comment. I don't really think we maintain much beside cluster membership using zookeeper. I think this is a reasonable descritpion for now.
exec/java-exec/src/main/java/org/apache/drill/exec/package-info.java
<https://reviews.apache.org/r/29278/#comment114443>
I have fixed the comment to include a link.
I started writing a more complete intro for new developers, but it was getting a bit long without covering the breadth I wanted. I have opened a JIRA for better starting documentation for new developers here as well as on the Wiki. I would like to get this patch in sooner to encourge others to write docs with a consistent style and format, but I will be trying to fit in an improvement to this documentation soon.
https://issues.apache.org/jira/browse/DRILL-2077
- Jason Altekruse
On Jan. 15, 2015, 10:16 p.m., Jason Altekruse wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29278/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2015, 10:16 p.m.)
>
>
> Review request for drill, Daniel Barclay and Jacques Nadeau.
>
>
> Bugs: Drill-1904
> https://issues.apache.org/jira/browse/Drill-1904
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Add package level documentation to the sources of Drill
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/drill/common/config/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/exceptions/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/expression/aggregate/BasicAggregates.java 5f18aaf
> common/src/main/java/org/apache/drill/common/expression/fn/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/expression/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/expression/types/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/expression/visitors/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/graph/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/logical/FormatPluginConfig.java 936e4f2
> common/src/main/java/org/apache/drill/common/logical/FormatPluginConfigBase.java 0704085
> common/src/main/java/org/apache/drill/common/logical/data/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/logical/data/visitors/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/logical/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/types/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/util/package-info.java PRE-CREATION
> contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/cache/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/client/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/compile/bytecode/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/compile/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/compile/sig/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/coord/local/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/coord/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/disk/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/dotdrill/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/exception/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/package-info.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29278/diff/
>
>
> Testing
> -------
>
> Just comments, no code changes
>
>
> Thanks,
>
> Jason Altekruse
>
>
Re: Review Request 29278: Drill-1904 package level docs
Posted by Sudheesh Katkam <sk...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29278/#review91945
-----------------------------------------------------------
LGTM!
common/src/main/java/org/apache/drill/common/expression/package-info.java (line 22)
<https://reviews.apache.org/r/29278/#comment145710>
conditions, as well as
common/src/main/java/org/apache/drill/common/expression/package-info.java (line 24)
<https://reviews.apache.org/r/29278/#comment145711>
logically as ASTs
common/src/main/java/org/apache/drill/common/logical/FormatPluginConfig.java (line 27)
<https://reviews.apache.org/r/29278/#comment145713>
such formats like as?
- Sudheesh Katkam
On Jan. 27, 2015, 1:36 a.m., Jason Altekruse wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29278/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2015, 1:36 a.m.)
>
>
> Review request for drill, Daniel Barclay and Jacques Nadeau.
>
>
> Bugs: Drill-1904
> https://issues.apache.org/jira/browse/Drill-1904
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Add package level documentation to the sources of Drill
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/drill/common/config/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/exceptions/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/expression/aggregate/BasicAggregates.java 5f18aaf
> common/src/main/java/org/apache/drill/common/expression/fn/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/expression/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/expression/types/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/expression/visitors/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/graph/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/logical/FormatPluginConfig.java 936e4f2
> common/src/main/java/org/apache/drill/common/logical/FormatPluginConfigBase.java 0704085
> common/src/main/java/org/apache/drill/common/logical/data/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/logical/data/visitors/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/logical/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/types/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/util/package-info.java PRE-CREATION
> contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/cache/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/client/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/compile/bytecode/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/compile/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/compile/sig/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/coord/local/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/coord/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/disk/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/dotdrill/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/exception/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/package-info.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29278/diff/
>
>
> Testing
> -------
>
> Just comments, no code changes
>
>
> Thanks,
>
> Jason Altekruse
>
>
Re: Review Request 29278: Drill-1904 package level docs
Posted by Parth Chandra <pc...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29278/#review91947
-----------------------------------------------------------
Ship it!
Ship It!
- Parth Chandra
On Jan. 27, 2015, 1:36 a.m., Jason Altekruse wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29278/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2015, 1:36 a.m.)
>
>
> Review request for drill, Daniel Barclay and Jacques Nadeau.
>
>
> Bugs: Drill-1904
> https://issues.apache.org/jira/browse/Drill-1904
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Add package level documentation to the sources of Drill
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/drill/common/config/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/exceptions/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/expression/aggregate/BasicAggregates.java 5f18aaf
> common/src/main/java/org/apache/drill/common/expression/fn/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/expression/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/expression/types/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/expression/visitors/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/graph/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/logical/FormatPluginConfig.java 936e4f2
> common/src/main/java/org/apache/drill/common/logical/FormatPluginConfigBase.java 0704085
> common/src/main/java/org/apache/drill/common/logical/data/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/logical/data/visitors/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/logical/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/types/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/util/package-info.java PRE-CREATION
> contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/cache/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/client/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/compile/bytecode/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/compile/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/compile/sig/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/coord/local/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/coord/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/disk/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/dotdrill/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/exception/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/package-info.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29278/diff/
>
>
> Testing
> -------
>
> Just comments, no code changes
>
>
> Thanks,
>
> Jason Altekruse
>
>
Re: Review Request 29278: Drill-1904 package level docs
Posted by Jason Altekruse <al...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29278/
-----------------------------------------------------------
(Updated Jan. 27, 2015, 1:36 a.m.)
Review request for drill, Daniel Barclay and Jacques Nadeau.
Changes
-------
Addressed Ted's comments
Bugs: Drill-1904
https://issues.apache.org/jira/browse/Drill-1904
Repository: drill-git
Description
-------
Add package level documentation to the sources of Drill
Diffs (updated)
-----
common/src/main/java/org/apache/drill/common/config/package-info.java PRE-CREATION
common/src/main/java/org/apache/drill/common/exceptions/package-info.java PRE-CREATION
common/src/main/java/org/apache/drill/common/expression/aggregate/BasicAggregates.java 5f18aaf
common/src/main/java/org/apache/drill/common/expression/fn/package-info.java PRE-CREATION
common/src/main/java/org/apache/drill/common/expression/package-info.java PRE-CREATION
common/src/main/java/org/apache/drill/common/expression/types/package-info.java PRE-CREATION
common/src/main/java/org/apache/drill/common/expression/visitors/package-info.java PRE-CREATION
common/src/main/java/org/apache/drill/common/graph/package-info.java PRE-CREATION
common/src/main/java/org/apache/drill/common/logical/FormatPluginConfig.java 936e4f2
common/src/main/java/org/apache/drill/common/logical/FormatPluginConfigBase.java 0704085
common/src/main/java/org/apache/drill/common/logical/data/package-info.java PRE-CREATION
common/src/main/java/org/apache/drill/common/logical/data/visitors/package-info.java PRE-CREATION
common/src/main/java/org/apache/drill/common/logical/package-info.java PRE-CREATION
common/src/main/java/org/apache/drill/common/package-info.java PRE-CREATION
common/src/main/java/org/apache/drill/common/types/package-info.java PRE-CREATION
common/src/main/java/org/apache/drill/common/util/package-info.java PRE-CREATION
contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/package-info.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/cache/package-info.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/client/package-info.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/compile/bytecode/package-info.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/compile/package-info.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/compile/sig/package-info.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/coord/local/package-info.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/coord/package-info.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/package-info.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/disk/package-info.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/dotdrill/package-info.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/exception/package-info.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/package-info.java PRE-CREATION
Diff: https://reviews.apache.org/r/29278/diff/
Testing
-------
Just comments, no code changes
Thanks,
Jason Altekruse
Re: Review Request 29278: Drill-1904 package level docs
Posted by Jason Altekruse <al...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29278/
-----------------------------------------------------------
(Updated Jan. 15, 2015, 10:16 p.m.)
Review request for drill, Daniel Barclay and Jacques Nadeau.
Changes
-------
Standardized wrapping to 80 characters.
Bugs: Drill-1904
https://issues.apache.org/jira/browse/Drill-1904
Repository: drill-git
Description
-------
Add package level documentation to the sources of Drill
Diffs (updated)
-----
common/src/main/java/org/apache/drill/common/config/package-info.java PRE-CREATION
common/src/main/java/org/apache/drill/common/exceptions/package-info.java PRE-CREATION
common/src/main/java/org/apache/drill/common/expression/aggregate/BasicAggregates.java 5f18aaf
common/src/main/java/org/apache/drill/common/expression/fn/package-info.java PRE-CREATION
common/src/main/java/org/apache/drill/common/expression/package-info.java PRE-CREATION
common/src/main/java/org/apache/drill/common/expression/types/package-info.java PRE-CREATION
common/src/main/java/org/apache/drill/common/expression/visitors/package-info.java PRE-CREATION
common/src/main/java/org/apache/drill/common/graph/package-info.java PRE-CREATION
common/src/main/java/org/apache/drill/common/logical/FormatPluginConfig.java 936e4f2
common/src/main/java/org/apache/drill/common/logical/FormatPluginConfigBase.java 0704085
common/src/main/java/org/apache/drill/common/logical/data/package-info.java PRE-CREATION
common/src/main/java/org/apache/drill/common/logical/data/visitors/package-info.java PRE-CREATION
common/src/main/java/org/apache/drill/common/logical/package-info.java PRE-CREATION
common/src/main/java/org/apache/drill/common/package-info.java PRE-CREATION
common/src/main/java/org/apache/drill/common/types/package-info.java PRE-CREATION
common/src/main/java/org/apache/drill/common/util/package-info.java PRE-CREATION
contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/package-info.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/cache/package-info.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/client/package-info.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/compile/bytecode/package-info.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/compile/package-info.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/compile/sig/package-info.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/coord/local/package-info.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/coord/package-info.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/package-info.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/disk/package-info.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/dotdrill/package-info.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/exception/package-info.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/package-info.java PRE-CREATION
Diff: https://reviews.apache.org/r/29278/diff/
Testing
-------
Just comments, no code changes
Thanks,
Jason Altekruse
Re: Review Request 29278: Drill-1904 package level docs
Posted by Jason Altekruse <al...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29278/
-----------------------------------------------------------
(Updated Jan. 13, 2015, 7:37 p.m.)
Review request for drill, Daniel Barclay and Jacques Nadeau.
Changes
-------
Updated with Daniel's edits. Added license headers to make RAT happy.
Bugs: Drill-1904
https://issues.apache.org/jira/browse/Drill-1904
Repository: drill-git
Description
-------
Add package level documentation to the sources of Drill
Diffs (updated)
-----
common/src/main/java/org/apache/drill/common/config/package-info.java PRE-CREATION
common/src/main/java/org/apache/drill/common/exceptions/package-info.java PRE-CREATION
common/src/main/java/org/apache/drill/common/expression/aggregate/BasicAggregates.java 5f18aaf
common/src/main/java/org/apache/drill/common/expression/fn/package-info.java PRE-CREATION
common/src/main/java/org/apache/drill/common/expression/package-info.java PRE-CREATION
common/src/main/java/org/apache/drill/common/expression/types/package-info.java PRE-CREATION
common/src/main/java/org/apache/drill/common/expression/visitors/package-info.java PRE-CREATION
common/src/main/java/org/apache/drill/common/graph/package-info.java PRE-CREATION
common/src/main/java/org/apache/drill/common/logical/FormatPluginConfig.java 936e4f2
common/src/main/java/org/apache/drill/common/logical/FormatPluginConfigBase.java 0704085
common/src/main/java/org/apache/drill/common/logical/data/package-info.java PRE-CREATION
common/src/main/java/org/apache/drill/common/logical/data/visitors/package-info.java PRE-CREATION
common/src/main/java/org/apache/drill/common/logical/package-info.java PRE-CREATION
common/src/main/java/org/apache/drill/common/package-info.java PRE-CREATION
common/src/main/java/org/apache/drill/common/types/package-info.java PRE-CREATION
common/src/main/java/org/apache/drill/common/util/package-info.java PRE-CREATION
contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/package-info.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/cache/package-info.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/client/package-info.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/compile/bytecode/package-info.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/compile/package-info.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/compile/sig/package-info.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/coord/local/package-info.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/coord/package-info.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/package-info.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/disk/package-info.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/dotdrill/package-info.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/exception/package-info.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/package-info.java PRE-CREATION
Diff: https://reviews.apache.org/r/29278/diff/
Testing
-------
Just comments, no code changes
Thanks,
Jason Altekruse
Re: Review Request 29278: Drill-1904 package level docs
Posted by Daniel Barclay <db...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29278/#review67478
-----------------------------------------------------------
I think a next step for the package-level documentation is to put the packages into
Javadoc groups to organize and order the package listing on the Javadoc overview page.
(See http://docs.oracle.com/javase/7/docs/technotes/tools/solaris/javadoc.html#group and
http://maven.apache.org/plugins/maven-javadoc-plugin/examples/group-configuration.html .)
The packages for Drill's "published" APIs should probably be in the first group or
groups, to make it easy for us to see how they and their documentation is shaping up.
(The "published" APIs are the logically public (not just Java-public) APIs intended for
developer end users (developers developing against Drill, not developing Drill itself),
e.g., the Java Drill client API (DrillClient, UserClient, etc.), the Drill JDBC API, the
storage plugin provider API, and presumably the Drill server invocation API (Drillbit,
DrillConfig, etc.)
Since the end-user documentation probably should include a separately generated Javadoc
bundle that includes only the published interfaces (since developer end users won't care
about internal interface, and for more visibility of the code and the results of the
Javadoc comments we're starting to add, at least for now this developer bundle should
be generated with "-private".)
The next groups should probably be for major subcomponents, probably in bottom-up order,
except that generated classes should probably be last (to keep them out of the away) (if
we don't suppress them).
Editorial wording fixes:
- "Execution time exceptions." -> "Execution-time exceptions."
- "Java-based client for ..." -> "Java client API for ..." (since it's not a whole client, but the Java library for a client program to use for "...").
- "Drill execution engine, includes: ..." -> "Drill execution engine, including: ..." OR "Drill execution engine; includes: ..."
- "Logical (execution engine independent) element definitions." -> "Logical (execution-engine-independent) element definitions."
- "Connected graph representation " -> "Connected-graph representation"
- "Runtime code generation, compilation and bytecode manipulation utilities." -> "Runtime code-generation, compilation and bytecode-manipulation utilities."
- 'A single node 'cluster coordinator' used when running Drill locally.' -> 'A single-node "cluster coordinator" used when running Drill locally.' (Or "A single-node cluster coordinator used when running Drill locally.")
- "Interface for drill's interaction ..." -> "Interface for Drill's interaction ..."
- (The first-line package descriptions are nicely consistent (all noun phrases).)
- "Sub package: data - logical operators This package includes":
- "Sub package" -> "Subpackage"
- "operators This" -> "operators. This"
- "data - logical operators" -> "data: logical operators"
- "data" -> {@link org.apache.drill.common.logical.data}
- "a JDBC driver is available as well, see ..." -> "a JDBC driver is available as well; see ..." ->
- (nice linking to org.apache.drill.jdbc)
- "for generating type specific java code" -> "for generating type-specific Java code"
- "prompt runtime code generation for the expressions needed to for the operator to process" -> "prompt runtime code generation for the expressions is needed for the operator to process" ?
- "to re-compile and JIT optimize the" -> probably "to re-compile and JIT-optimize the"
- "stitching together runtime generated code with" -> "stitching together runtime-generated code with"
- "for small data only objects" -> "for small data-only objects"
- "defining user facing APIs" -> "defining user-facing APIs"
- "Interface for drill's interaction" -> "Interface for Drill's interaction"
- "... support 'spilling to disk'. These ...": Switch to double quotes (American English standard).
- "limits of a single machines memory" -> "limits of a single machine's memory"
- "other cluster persistent state" -> maybe "other cluster-persistent state" or "other cluster-wide persistent state" or maybe "other persistent cluster state"
Daniel
- Daniel Barclay
On Dec. 19, 2014, 11:40 p.m., Jason Altekruse wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29278/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2014, 11:40 p.m.)
>
>
> Review request for drill, Daniel Barclay and Jacques Nadeau.
>
>
> Bugs: Drill-1904
> https://issues.apache.org/jira/browse/Drill-1904
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Add package level documentation to the sources of Drill
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/drill/common/config/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/exceptions/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/expression/aggregate/BasicAggregates.java 5f18aaf
> common/src/main/java/org/apache/drill/common/expression/fn/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/expression/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/expression/types/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/expression/visitors/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/graph/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/logical/FormatPluginConfig.java 936e4f2
> common/src/main/java/org/apache/drill/common/logical/FormatPluginConfigBase.java 0704085
> common/src/main/java/org/apache/drill/common/logical/data/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/logical/data/visitors/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/logical/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/types/package-info.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/util/package-info.java PRE-CREATION
> contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/cache/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/client/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/compile/bytecode/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/compile/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/compile/sig/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/coord/local/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/coord/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/disk/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/dotdrill/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/exception/package-info.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/package-info.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29278/diff/
>
>
> Testing
> -------
>
> Just comments, no code changes
>
>
> Thanks,
>
> Jason Altekruse
>
>