You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Riza Suminto (Code Review)" <ge...@cloudera.org> on 2025/09/11 20:11:50 UTC
[Impala-ASF-CR] IMPALA-14426: Deflake TestImpalaShell.test cancellation
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23416
Change subject: IMPALA-14426: Deflake TestImpalaShell.test_cancellation
......................................................................
IMPALA-14426: Deflake TestImpalaShell.test_cancellation
TestImpalaShell.test_cancellation start failing when run with Python 3.9
with following error message
RuntimeError: reentrant call inside <_io.BufferedWriter name='<stderr>'>
This patch fix the issue by changing the stderr write from using print()
to os.write().
Testing:
Run and pass test_cancellation in RHEL9 with Python 3.9.
Change-Id: I5403c7b8126b1a35ea841496fdfb6eb93e83376e
---
M shell/impala_shell/impala_shell.py
1 file changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/23416/1
--
To view, visit http://gerrit.cloudera.org:8080/23416
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5403c7b8126b1a35ea841496fdfb6eb93e83376e
Gerrit-Change-Number: 23416
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-14426: Deflake TestImpalaShell.test cancellation
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Daniel Vanko, Csaba Ringhofer, Noemi Pap-Takacs, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23416
to look at the new patch set (#4).
Change subject: IMPALA-14426: Deflake TestImpalaShell.test_cancellation
......................................................................
IMPALA-14426: Deflake TestImpalaShell.test_cancellation
TestImpalaShell.test_cancellation start failing when run with Python 3.9
with following error message
RuntimeError: reentrant call inside <_io.BufferedWriter name='<stderr>'>
This patch is a quick fix the by changing the stderr write from using
print() to os.write(). Note that the thread-safetyness isssue within
_signal_handler in impala_shell.py during query cancellation still
remains.
Testing:
Run and pass test_cancellation in RHEL9 with Python 3.9.
Change-Id: I5403c7b8126b1a35ea841496fdfb6eb93e83376e
---
M shell/impala_shell/impala_shell.py
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/23416/4
--
To view, visit http://gerrit.cloudera.org:8080/23416
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5403c7b8126b1a35ea841496fdfb6eb93e83376e
Gerrit-Change-Number: 23416
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-14426: Deflake TestImpalaShell.test cancellation
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23416 )
Change subject: IMPALA-14426: Deflake TestImpalaShell.test_cancellation
......................................................................
Patch Set 1:
(1 comment)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/23416/1/shell/impala_shell/impala_shell.py
File shell/impala_shell/impala_shell.py:
http://gerrit.cloudera.org:8080/#/c/23416/1/shell/impala_shell/impala_shell.py@759
PS1, Line 759: )
flake8: E123 closing bracket does not match indentation of opening bracket's line
--
To view, visit http://gerrit.cloudera.org:8080/23416
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5403c7b8126b1a35ea841496fdfb6eb93e83376e
Gerrit-Change-Number: 23416
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Sep 2025 20:14:06 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14426: Deflake TestImpalaShell.test cancellation
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23416 )
Change subject: IMPALA-14426: Deflake TestImpalaShell.test_cancellation
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12471/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/23416
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5403c7b8126b1a35ea841496fdfb6eb93e83376e
Gerrit-Change-Number: 23416
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Sep 2025 15:38:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14426: Deflake TestImpalaShell.test cancellation
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23416 )
Change subject: IMPALA-14426: Deflake TestImpalaShell.test_cancellation
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/23416
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5403c7b8126b1a35ea841496fdfb6eb93e83376e
Gerrit-Change-Number: 23416
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Sep 2025 20:49:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14426: Deflake TestImpalaShell.test cancellation
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23416 )
Change subject: IMPALA-14426: Deflake TestImpalaShell.test_cancellation
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/23416/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/23416/2//COMMIT_MSG@7
PS2, Line 7: Deflake TestImpalaShell.test_cancellation
> I'm not sure if there is anything else that we overlook. But looping test_c
ack, lets merge it and see if other tests catch something
--
To view, visit http://gerrit.cloudera.org:8080/23416
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5403c7b8126b1a35ea841496fdfb6eb93e83376e
Gerrit-Change-Number: 23416
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Sep 2025 15:37:57 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14426: Deflake TestImpalaShell.test cancellation
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23416 )
Change subject: IMPALA-14426: Deflake TestImpalaShell.test_cancellation
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/23416
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5403c7b8126b1a35ea841496fdfb6eb93e83376e
Gerrit-Change-Number: 23416
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Sep 2025 15:38:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14426: Deflake TestImpalaShell.test cancellation
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Daniel Vanko, Csaba Ringhofer, Noemi Pap-Takacs, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23416
to look at the new patch set (#2).
Change subject: IMPALA-14426: Deflake TestImpalaShell.test_cancellation
......................................................................
IMPALA-14426: Deflake TestImpalaShell.test_cancellation
TestImpalaShell.test_cancellation start failing when run with Python 3.9
with following error message
RuntimeError: reentrant call inside <_io.BufferedWriter name='<stderr>'>
This patch fix the issue by changing the stderr write from using print()
to os.write().
Testing:
Run and pass test_cancellation in RHEL9 with Python 3.9.
Change-Id: I5403c7b8126b1a35ea841496fdfb6eb93e83376e
---
M shell/impala_shell/impala_shell.py
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/23416/2
--
To view, visit http://gerrit.cloudera.org:8080/23416
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5403c7b8126b1a35ea841496fdfb6eb93e83376e
Gerrit-Change-Number: 23416
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-14426: Deflake TestImpalaShell.test cancellation
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23416 )
Change subject: IMPALA-14426: Deflake TestImpalaShell.test_cancellation
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/20456/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/23416
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5403c7b8126b1a35ea841496fdfb6eb93e83376e
Gerrit-Change-Number: 23416
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Sep 2025 20:39:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14426: Deflake TestImpalaShell.test cancellation
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23416 )
Change subject: IMPALA-14426: Deflake TestImpalaShell.test_cancellation
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/23416/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/23416/2//COMMIT_MSG@7
PS2, Line 7: Deflake TestImpalaShell.test_cancellation
Is this really just a test issue? Can't we have problems (at least not informative error message) when using impala-shell in Python 3 and pressing CTRL+c ?
http://gerrit.cloudera.org:8080/#/c/23416/2/shell/impala_shell/impala_shell.py
File shell/impala_shell/impala_shell.py:
http://gerrit.cloudera.org:8080/#/c/23416/2/shell/impala_shell/impala_shell.py@740
PS2, Line 740: new_imp_client = self._new_impala_client()
: new_imp_client.connect()
: try:
: new_imp_client.cancel_query(self.last_query_handle)
: new_imp_client.close_query(self.last_query_handle)
Can't we have other similar issues if these functions do some logging? There is already a TODO in line 733 about thread safety.
I think that it would be better to start another thread to cancel the query:
1. start a new thread to cancel the query
2. raise KeyboardInterrupt()
3. in the code that catches KeyboardInterrupt wait for the cancellation to finish before doing something new
I am ok with not doing this in the current patch, but the commit message should not that this is just a quick fix.
--
To view, visit http://gerrit.cloudera.org:8080/23416
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5403c7b8126b1a35ea841496fdfb6eb93e83376e
Gerrit-Change-Number: 23416
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Sep 2025 07:02:47 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14426: Deflake TestImpalaShell.test cancellation
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23416 )
Change subject: IMPALA-14426: Deflake TestImpalaShell.test_cancellation
......................................................................
IMPALA-14426: Deflake TestImpalaShell.test_cancellation
TestImpalaShell.test_cancellation start failing when run with Python 3.9
with following error message
RuntimeError: reentrant call inside <_io.BufferedWriter name='<stderr>'>
This patch is a quick fix the by changing the stderr write from using
print() to os.write(). Note that the thread-safetyness isssue within
_signal_handler in impala_shell.py during query cancellation still
remains.
Testing:
Run and pass test_cancellation in RHEL9 with Python 3.9.
Change-Id: I5403c7b8126b1a35ea841496fdfb6eb93e83376e
Reviewed-on: http://gerrit.cloudera.org:8080/23416
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M shell/impala_shell/impala_shell.py
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/23416
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5403c7b8126b1a35ea841496fdfb6eb93e83376e
Gerrit-Change-Number: 23416
Gerrit-PatchSet: 6
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-14426: Deflake TestImpalaShell.test cancellation
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23416 )
Change subject: IMPALA-14426: Deflake TestImpalaShell.test_cancellation
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/20459/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/23416
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5403c7b8126b1a35ea841496fdfb6eb93e83376e
Gerrit-Change-Number: 23416
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Sep 2025 20:49:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14426: Deflake TestImpalaShell.test cancellation
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23416 )
Change subject: IMPALA-14426: Deflake TestImpalaShell.test_cancellation
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/23416/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/23416/2//COMMIT_MSG@7
PS2, Line 7: Deflake TestImpalaShell.test_cancellation
> Is this really just a test issue? Can't we have problems (at least not info
I'm not sure if there is anything else that we overlook. But looping test_cancellation does not reveal anything else. All pass.
Perhaps we shall see something else once in downstream tests once we merged this?
http://gerrit.cloudera.org:8080/#/c/23416/2/shell/impala_shell/impala_shell.py
File shell/impala_shell/impala_shell.py:
http://gerrit.cloudera.org:8080/#/c/23416/2/shell/impala_shell/impala_shell.py@740
PS2, Line 740: new_imp_client = self._new_impala_client()
: new_imp_client.connect()
: try:
: new_imp_client.cancel_query(self.last_query_handle)
: new_imp_client.close_query(self.last_query_handle)
> Can't we have other similar issues if these functions do some logging? Ther
Agree that we might have similar issue if this code block does logging anywhere.
Fortunately, searching around impala_client.py, that does not seem to be the case.
--
To view, visit http://gerrit.cloudera.org:8080/23416
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5403c7b8126b1a35ea841496fdfb6eb93e83376e
Gerrit-Change-Number: 23416
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Sep 2025 15:06:39 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14426: Deflake TestImpalaShell.test cancellation
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Daniel Vanko, Csaba Ringhofer, Noemi Pap-Takacs, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23416
to look at the new patch set (#3).
Change subject: IMPALA-14426: Deflake TestImpalaShell.test_cancellation
......................................................................
IMPALA-14426: Deflake TestImpalaShell.test_cancellation
TestImpalaShell.test_cancellation start failing when run with Python 3.9
with following error message
RuntimeError: reentrant call inside <_io.BufferedWriter name='<stderr>'>
This patch is a quick ix the by changing the stderr write from using
print() to os.write(). Note that the thread-safetyness isssue within
_signal_handler in impala_shell.py during query cancellation still
remains.
Testing:
Run and pass test_cancellation in RHEL9 with Python 3.9.
Change-Id: I5403c7b8126b1a35ea841496fdfb6eb93e83376e
---
M shell/impala_shell/impala_shell.py
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/23416/3
--
To view, visit http://gerrit.cloudera.org:8080/23416
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5403c7b8126b1a35ea841496fdfb6eb93e83376e
Gerrit-Change-Number: 23416
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>