[GitHub] [apisix] leslie-tsang commented on a change in pull request #5319: test: grpc stream proxy test with test nginx

[GitBox <gi...@apache.org>]

leslie-tsang commented on a change in pull request #5319:
URL: https://github.com/apache/apisix/pull/5319#discussion_r735018086



##########
File path: ci/linux_openresty_common_runner.sh
##########
@@ -44,18 +44,15 @@ do_install() {
     make utils
 
     mkdir -p build-cache
-    if [ ! -f "build-cache/grpc_server_example_$GRPC_SERVER_EXAMPLE_VER" ]; then
-        wget https://github.com/api7/grpc_server_example/releases/download/"$GRPC_SERVER_EXAMPLE_VER"/grpc_server_example-amd64.tar.gz
-        tar -xvf grpc_server_example-amd64.tar.gz
-        mv grpc_server_example build-cache/
+    # install and start grpc_server_example
+    cd t/grpc_server_example
 
-        git clone --depth 1 https://github.com/api7/grpc_server_example.git grpc_server_example
-        pushd grpc_server_example/ || exit 1
-        mv proto/ ../build-cache/
-        popd || exit 1
-
-        touch build-cache/grpc_server_example_"$GRPC_SERVER_EXAMPLE_VER"
-    fi
+    if [ ! "$(ls -A . )" ]; then # for local development only
+     git submodule init
+     git submodule update
+	fi

Review comment:
       ```suggestion
       if [ ! "$(ls -A . )" ]; then # for local development only
           git submodule init
           git submodule update
       fi
   ```
   Ditto.

##########
File path: ci/centos7-ci.sh
##########
@@ -42,18 +42,25 @@ install_dependencies() {
     yum install -y cpanminus perl
     cpanm --notest Test::Nginx IPC::Run > build.log 2>&1 || (cat build.log && exit 1)
 
-    # install and start grpc_server_example
+    # add go1.15 binary to the path
     mkdir build-cache
-    wget https://github.com/api7/grpc_server_example/releases/download/"$GRPC_SERVER_EXAMPLE_VER"/grpc_server_example-amd64.tar.gz
-    tar -xvf grpc_server_example-amd64.tar.gz
-    mv grpc_server_example build-cache/
-    git clone https://github.com/iresty/grpc_server_example.git grpc_server_example
-    cd grpc_server_example/ && mv proto/ ../build-cache/ && cd ..
-    ./build-cache/grpc_server_example \
+    cd build-cache/ && wget https://golang.org/dl/go1.15.linux-amd64.tar.gz && tar -xf go1.15.linux-amd64.tar.gz
+    export PATH=$PATH:$(pwd)/go/bin
+    cd ..
+    # install and start grpc_server_example
+    cd t/grpc_server_example
+
+    if [ ! "$(ls -A . )" ]; then
+     git submodule init
+     git submodule update
+	fi

Review comment:
       ```suggestion
       if [ ! "$(ls -A . )" ]; then
           git submodule init
           git submodule update
       fi
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org