You are viewing a plain text version of this content. The canonical link for it is here.
Posted to axis-cvs@ws.apache.org by du...@apache.org on 2006/01/18 17:51:41 UTC

svn commit: r370182 - /webservices/axis/trunk/java/src/org/apache/axis/encoding/SerializationContext.java

Author: dug
Date: Wed Jan 18 08:51:39 2006
New Revision: 370182

URL: http://svn.apache.org/viewcvs?rev=370182&view=rev
Log:
Hopefully this won't hurt people - in fact I hope it helps.
By default Axis should not pretty print the XML, it will
totally mess-up security verification of messages. If people
really want this then they should use one of the util to 
pretty-up their xml - or they can set it themselves, but the
default should not screw with people's xml.

Modified:
    webservices/axis/trunk/java/src/org/apache/axis/encoding/SerializationContext.java

Modified: webservices/axis/trunk/java/src/org/apache/axis/encoding/SerializationContext.java
URL: http://svn.apache.org/viewcvs/webservices/axis/trunk/java/src/org/apache/axis/encoding/SerializationContext.java?rev=370182&r1=370181&r2=370182&view=diff
==============================================================================
--- webservices/axis/trunk/java/src/org/apache/axis/encoding/SerializationContext.java (original)
+++ webservices/axis/trunk/java/src/org/apache/axis/encoding/SerializationContext.java Wed Jan 18 08:51:39 2006
@@ -126,7 +126,7 @@
     /**
      * Should I disable the pretty xml completely.
      */ 
-    private boolean disablePrettyXML = false;
+    private boolean disablePrettyXML = true;
 
 
     /**
@@ -1732,4 +1732,4 @@
     public void setItemType(QName itemType) {
         this.itemType = itemType;
     }
-}
\ No newline at end of file
+}

RE: svn commit: r370182 - /webservices/axis/trunk/java/src/org/apache/axis/encoding/SerializationContext.java

Posted by Tom Jordahl <tj...@adobe.com>.
No problem, I am only -0 on this change.  Hey tcpmon will format the XML
for you...

 

But I am giving anyone of my customers who complains your email address.
:-)

 

--

Tom Jordahl

Adobe ColdFusion Team

________________________________

From: Doug Davis [mailto:dug@us.ibm.com] 
Sent: Wednesday, January 18, 2006 4:49 PM
To: Tom Jordahl
Cc: axis-dev@ws.apache.org; dug@apache.org
Subject: RE: svn commit: r370182 -
/webservices/axis/trunk/java/src/org/apache/axis/encoding/SerializationC
ontext.java

 


Yes!  I know of at least one other person that ran into this problem.
The idea 
that the soap engine by default messes with your XML is just plain
wrong.  If 
people want to have their XML messed with then they can ask for it.   
I spent hours trying to figure out why my security code wasn't working
and 
I think it would be in Axis' best interest if it could avoid making
people 
who don't know about some special wsdd option from going through the 
same negative experience that I did.  We should probably remove 
or change the default wsdd files - I just noticed they set this option
incorrectly too. 
-Doug 




"Tom Jordahl" <tj...@adobe.com> 

01/18/2006 04:29 PM 

To

<du...@apache.org> 

cc

<ax...@ws.apache.org> 

Subject

RE: svn commit: r370182 -
/webservices/axis/trunk/java/src/org/apache/axis/encoding/SerializationC
ontext.java

 

 

 




Dug,

Uh - we have a property in the wsdd files that controls this...
And I believe that the security code turns this off itself.

Are you *sure* we want to change this?

--
Tom Jordahl
Adobe ColdFusion Team

-----Original Message-----
From: dug@apache.org [mailto:dug@apache.org] 
Sent: Wednesday, January 18, 2006 11:52 AM
To: axis-cvs@ws.apache.org
Subject: svn commit: r370182 -
/webservices/axis/trunk/java/src/org/apache/axis/encoding/SerializationC
ontext.java

Author: dug
Date: Wed Jan 18 08:51:39 2006
New Revision: 370182

URL: http://svn.apache.org/viewcvs?rev=370182&view=rev
Log:
Hopefully this won't hurt people - in fact I hope it helps.
By default Axis should not pretty print the XML, it will
totally mess-up security verification of messages. If people
really want this then they should use one of the util to 
pretty-up their xml - or they can set it themselves, but the
default should not screw with people's xml.

Modified:

webservices/axis/trunk/java/src/org/apache/axis/encoding/SerializationCo
ntext.java

Modified:
webservices/axis/trunk/java/src/org/apache/axis/encoding/SerializationCo
ntext.java
URL:
http://svn.apache.org/viewcvs/webservices/axis/trunk/java/src/org/apache
/axis/encoding/SerializationContext.java?rev=370182&r1=370181&r2=370182&
view=diff
========================================================================
======
---
webservices/axis/trunk/java/src/org/apache/axis/encoding/SerializationCo
ntext.java (original)
+++
webservices/axis/trunk/java/src/org/apache/axis/encoding/SerializationCo
ntext.java Wed Jan 18 08:51:39 2006
@@ -126,7 +126,7 @@
    /**
     * Should I disable the pretty xml completely.
     */ 
-    private boolean disablePrettyXML = false;
+    private boolean disablePrettyXML = true;


    /**
@@ -1732,4 +1732,4 @@
    public void setItemType(QName itemType) {
        this.itemType = itemType;
    }
-}
\ No newline at end of file
+}

RE: svn commit: r370182 - /webservices/axis/trunk/java/src/org/apache/axis/encoding/SerializationContext.java

Posted by Doug Davis <du...@us.ibm.com>.
Yes!  I know of at least one other person that ran into this problem.  The 
idea
that the soap engine by default messes with your XML is just plain wrong. 
If
people want to have their XML messed with then they can ask for it. 
I spent hours trying to figure out why my security code wasn't working and
I think it would be in Axis' best interest if it could avoid making people
who don't know about some special wsdd option from going through the
same negative experience that I did.  We should probably remove
or change the default wsdd files - I just noticed they set this option 
incorrectly too.
-Doug




"Tom Jordahl" <tj...@adobe.com> 
01/18/2006 04:29 PM

To
<du...@apache.org>
cc
<ax...@ws.apache.org>
Subject
RE: svn commit: r370182 - 
/webservices/axis/trunk/java/src/org/apache/axis/encoding/SerializationContext.java






Dug,

Uh - we have a property in the wsdd files that controls this...
And I believe that the security code turns this off itself.

Are you *sure* we want to change this?

--
Tom Jordahl
Adobe ColdFusion Team

-----Original Message-----
From: dug@apache.org [mailto:dug@apache.org] 
Sent: Wednesday, January 18, 2006 11:52 AM
To: axis-cvs@ws.apache.org
Subject: svn commit: r370182 -
/webservices/axis/trunk/java/src/org/apache/axis/encoding/SerializationC
ontext.java

Author: dug
Date: Wed Jan 18 08:51:39 2006
New Revision: 370182

URL: http://svn.apache.org/viewcvs?rev=370182&view=rev
Log:
Hopefully this won't hurt people - in fact I hope it helps.
By default Axis should not pretty print the XML, it will
totally mess-up security verification of messages. If people
really want this then they should use one of the util to 
pretty-up their xml - or they can set it themselves, but the
default should not screw with people's xml.

Modified:
 
webservices/axis/trunk/java/src/org/apache/axis/encoding/SerializationCo
ntext.java

Modified:
webservices/axis/trunk/java/src/org/apache/axis/encoding/SerializationCo
ntext.java
URL:
http://svn.apache.org/viewcvs/webservices/axis/trunk/java/src/org/apache
/axis/encoding/SerializationContext.java?rev=370182&r1=370181&r2=370182&
view=diff
========================================================================
======
---
webservices/axis/trunk/java/src/org/apache/axis/encoding/SerializationCo
ntext.java (original)
+++
webservices/axis/trunk/java/src/org/apache/axis/encoding/SerializationCo
ntext.java Wed Jan 18 08:51:39 2006
@@ -126,7 +126,7 @@
     /**
      * Should I disable the pretty xml completely.
      */ 
-    private boolean disablePrettyXML = false;
+    private boolean disablePrettyXML = true;
 
 
     /**
@@ -1732,4 +1732,4 @@
     public void setItemType(QName itemType) {
         this.itemType = itemType;
     }
-}
\ No newline at end of file
+}

RE: svn commit: r370182 - /webservices/axis/trunk/java/src/org/apache/axis/encoding/SerializationContext.java

Posted by Tom Jordahl <tj...@adobe.com>.
Dug,

Uh - we have a property in the wsdd files that controls this...
And I believe that the security code turns this off itself.

Are you *sure* we want to change this?

--
Tom Jordahl
Adobe ColdFusion Team

-----Original Message-----
From: dug@apache.org [mailto:dug@apache.org] 
Sent: Wednesday, January 18, 2006 11:52 AM
To: axis-cvs@ws.apache.org
Subject: svn commit: r370182 -
/webservices/axis/trunk/java/src/org/apache/axis/encoding/SerializationC
ontext.java

Author: dug
Date: Wed Jan 18 08:51:39 2006
New Revision: 370182

URL: http://svn.apache.org/viewcvs?rev=370182&view=rev
Log:
Hopefully this won't hurt people - in fact I hope it helps.
By default Axis should not pretty print the XML, it will
totally mess-up security verification of messages. If people
really want this then they should use one of the util to 
pretty-up their xml - or they can set it themselves, but the
default should not screw with people's xml.

Modified:
 
webservices/axis/trunk/java/src/org/apache/axis/encoding/SerializationCo
ntext.java

Modified:
webservices/axis/trunk/java/src/org/apache/axis/encoding/SerializationCo
ntext.java
URL:
http://svn.apache.org/viewcvs/webservices/axis/trunk/java/src/org/apache
/axis/encoding/SerializationContext.java?rev=370182&r1=370181&r2=370182&
view=diff
========================================================================
======
---
webservices/axis/trunk/java/src/org/apache/axis/encoding/SerializationCo
ntext.java (original)
+++
webservices/axis/trunk/java/src/org/apache/axis/encoding/SerializationCo
ntext.java Wed Jan 18 08:51:39 2006
@@ -126,7 +126,7 @@
     /**
      * Should I disable the pretty xml completely.
      */ 
-    private boolean disablePrettyXML = false;
+    private boolean disablePrettyXML = true;
 
 
     /**
@@ -1732,4 +1732,4 @@
     public void setItemType(QName itemType) {
         this.itemType = itemType;
     }
-}
\ No newline at end of file
+}