[GitHub] [arrow] jorisvandenbossche commented on a diff in pull request #34445: GH-34283 [Python] Add types_mapper support to index for to_pandas

["jorisvandenbossche (via GitHub)" <gi...@apache.org>]

jorisvandenbossche commented on code in PR #34445:
URL: https://github.com/apache/arrow/pull/34445#discussion_r1126178551


##########
python/pyarrow/tests/test_pandas.py:
##########
@@ -647,6 +647,23 @@ def test_mismatch_metadata_schema(self):
             result = new_table.to_pandas()
             tm.assert_frame_equal(result, expected)
 
+    @pytest.mark.parametrize("index", ["a", ["a", "b"]])
+    def test_to_pandas_types_mapper_index(self, index):

Review Comment:
   The other types_mapper related tests are lower in the file (not in one of the classes), so I would move it there (eg just below `test_roundtrip_empty_table_with_extension_dtype_index`)
   
   (Sidenote, seeing that `test_roundtrip_empty_table_with_extension_dtype_index` test, that seems to be something that should be fixed as well, preserving interval index)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org