[jira] [Commented] (CALCITE-749) Use a Factory in MaterializationService to create tables

["Julian Hyde (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14569931#comment-14569931 ] 

Julian Hyde commented on CALCITE-749:
-------------------------------------

In CalciteSchema, I think you can change getTable to return a TableEntry rather than a Pair<String, Table>, and fix up uses of that method. If the approach is successful you should also modify getTableBasedOnNullaryFunction and getTableEntryBySql in the same way. It breaks backwards compatibility, but CalciteSchema is not a public API.

> Use a Factory in MaterializationService to create tables
> --------------------------------------------------------
>
>                 Key: CALCITE-749
>                 URL: https://issues.apache.org/jira/browse/CALCITE-749
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Rajat Venkatesh
>            Assignee: Julian Hyde
>
> Follow up of this [conversation|https://mail-archives.apache.org/mod_mbox/incubator-calcite-dev/201503.mbox/%3CCANG6QPx7eLmUrkXRTY09yGw7GchMNRSSDnRCQEnd_3z%3DJCX%3Dgg%40mail.gmail.com%3E]
> There are two tasks:
> 1. Use a Factory to create tables that represent a materialized view.
> 2. Add an entry to the schema only if a materialized table was created in defineMaterialization.
> I'll open a WIP progress soon. 
> 1. was easy to implement.
> 2. is proving to be hard because rest of the code requires a CalciteSchema.TableEntry object which is available only when a table is added to schema. I dont know how to get an object for an existing entry.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)