You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/05/11 16:16:21 UTC

[GitHub] [superset] rusackas commented on a diff in pull request #19873: feat(css): adds `chartId`-based class to dashboard chart holder

rusackas commented on code in PR #19873:
URL: https://github.com/apache/superset/pull/19873#discussion_r870511577


##########
superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx:
##########
@@ -344,6 +344,7 @@ class ChartHolder extends React.Component {
               className={cx(
                 'dashboard-component',
                 'dashboard-component-chart-holder',
+                `dashboard-chart-id-${chartId}`,

Review Comment:
   ```suggestion
                   // The following class is added to support custom dashboard styling via the CSS editor
                   `dashboard-chart-id-${chartId}`,
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org