You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/07 09:20:21 UTC

[GitHub] [arrow] thisisnic commented on a change in pull request #12097: ARROW-14590: [R] Implement lubridate::week

thisisnic commented on a change in pull request #12097:
URL: https://github.com/apache/arrow/pull/12097#discussion_r780125202



##########
File path: r/tests/testthat/test-dplyr-funcs-datetime.R
##########
@@ -382,6 +382,15 @@ test_that("extract epiweek from timestamp", {
   )
 })
 
+test_that("extract week from timestamp", {

Review comment:
       This looks good!  Would you mind also adding a test for "extract week from date"?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org