[PR] arm64 fork: FORK_REG_LR,FORK_REG_SP should save the func local stack [nuttx]

["lipengfei28 (via GitHub)" <gi...@apache.org>]

lipengfei28 opened a new pull request, #13664:
URL: https://github.com/apache/nuttx/pull/13664

   not the last func stack
   FORK_REG_LR,FORK_REG_SP should save the func local stack not the last func stack
   ## Summary
   
   ## Impact
   
   ## Testing
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] arm64 fork: FORK_REG_LR,FORK_REG_SP should save the func local stack [nuttx]

["xiaoxiang781216 (via GitHub)" <gi...@apache.org>]

xiaoxiang781216 commented on PR #13664:
URL: https://github.com/apache/nuttx/pull/13664#issuecomment-2380559352

   @pussuw could you review thtis change?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] arm64 fork: FORK_REG_LR,FORK_REG_SP should save the func local stack [nuttx]

["nuttxpr (via GitHub)" <gi...@apache.org>]

nuttxpr commented on PR #13664:
URL: https://github.com/apache/nuttx/pull/13664#issuecomment-2378558001

   [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
   
   
   
   ## NuttX PR Requirements Review
   
   **Missing Information:** 
   
   This PR lacks crucial details to assess its compliance with NuttX requirements.  Let's break it down:
   
   **Summary:**
   
   * **Insufficient:** "not the last func stack FORK_REG_LR,FORK_REG_SP should save the func local stack not the last func stack" is vague. 
       * **What is the problem you are solving?**  Clearly state the bug or why this change is needed.
       * **What are FORK_REG_LR and FORK_REG_SP?** Provide context for someone unfamiliar with this code section. 
       * **What is the "func local stack"?**  Explain the difference between this and the "last func stack".
       * **Link to related issue(s):**  Is there a GitHub issue tracking this bug?
   
   **Impact:**
   
   * **Entirely missing:** You *must* address each impact category:
       * Feature changes?
       * User impact?
       * Build process changes?
       * Hardware implications?
       * Documentation needs?
       * Security concerns?
       * Compatibility (backward, forward, interoperability)?
       * Other considerations?
   
   **Testing:**
   
   * **Insufficient:** Simply stating "your testing logs here" is not helpful.
       * **Provide actual logs:**  Before and after the change, showing the problem and the solution.
       * **Specifics matter:** Mention:
           * Host OS and compiler used for building.
           * Target architecture and board configuration. 
   
   **Overall:**
   
   In its current state, this PR is **not ready** for review. It lacks the necessary information to understand the change, its impact, and how it has been tested. Please address each missing section with clear explanations and supporting details. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org