You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/20 04:00:25 UTC

[GitHub] [spark] HyukjinKwon commented on pull request #29812: [SPARK-32941][SQL] Optimize UpdateFields expression chain and put the rule early in Analysis phase

HyukjinKwon commented on pull request #29812:
URL: https://github.com/apache/spark/pull/29812#issuecomment-712573143


   @viirya, BTW, do you mind fixing the PR description to explain what this PR specifically improves?
   
   > This patch proposes to add more optimization to `UpdateFields` expression chain.
   
   Seems like this PR does not describe what exactly optimizes. Is my understanding correct that this PR proposes two separate optimizations?
   
   - Deduplicates `WithField` at `UpdateFields`
   - Respect nullability in input struct at `GetStructField(UpdateFields(..., struct))`, and unwrap if-else.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org