You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "epugh (via GitHub)" <gi...@apache.org> on 2025/08/23 09:46:59 UTC
[PR] SOLR-17864: Flip solr.hideStackTrace to .enabled equivalent. [solr]
epugh opened a new pull request, #3503:
URL: https://github.com/apache/solr/pull/3503
Tricky one because I didn't want to change the solr.xml name AS well, so now in solr.xml we have solr.hideStackTrace, but system is solr.responses.stacktrace.enabled.
Why is this in solr.xml?
https://issues.apache.org/jira/browse/SOLR-17864
I am going to leave this one for just this one, unless I find other solr.xml that are also system variable equivalents.. Then maybe this grows into a whole "why do we define these in solr.xml and in system variables?" disucssion!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17864: Flip solr.hideStackTrace to .enabled equivalent. [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh merged PR #3503:
URL: https://github.com/apache/solr/pull/3503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17864: Flip solr.hideStackTrace to .enabled equivalent. [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on code in PR #3503:
URL: https://github.com/apache/solr/pull/3503#discussion_r2296672385
##########
solr/solrj/src/resources/DeprecatedSystemPropertyMappings.properties:
##########
@@ -19,3 +19,4 @@ solr.enable.remote.streaming=solr.requests.streaming.remote.enabled
solr.enable.stream.body=solr.requests.streaming.body.enabled
solr.delete.unknown.cores=solr.cloud.startup.delete.unknown.cores.enabled
solr.config.set.forbidden.file.types=solr.configset.forbidden.file.types
+solr.hide.stack.trace=solr.responses.stacktrace.enabled
Review Comment:
Not a bad idea.. Maybe if the line starts with a `!` then you know while processing that it's an inversion. That would simplify the rule logic in EnvUtils.java.. This is a great idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17864: Flip solr.hideStackTrace to .enabled equivalent. [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on code in PR #3503:
URL: https://github.com/apache/solr/pull/3503#discussion_r2296337974
##########
solr/core/src/java/org/apache/solr/core/NodeConfig.java:
##########
@@ -618,7 +618,8 @@ public static class NodeConfigBuilder {
private String defaultZkHost;
private Set<Path> allowPaths = Collections.emptySet();
private List<String> allowUrls = Collections.emptyList();
- private boolean hideStackTrace = Boolean.getBoolean("solr.hideStackTrace");
+ private boolean hideStackTrace =
+ !(Boolean.parseBoolean(System.getProperty("solr.responses.stacktrace.enabled", "true")));
Review Comment:
EnvUtils?
##########
solr/solrj/src/resources/DeprecatedSystemPropertyMappings.properties:
##########
@@ -19,3 +19,4 @@ solr.enable.remote.streaming=solr.requests.streaming.remote.enabled
solr.enable.stream.body=solr.requests.streaming.body.enabled
solr.delete.unknown.cores=solr.cloud.startup.delete.unknown.cores.enabled
solr.config.set.forbidden.file.types=solr.configset.forbidden.file.types
+solr.hide.stack.trace=solr.responses.stacktrace.enabled
Review Comment:
it'd be neat if there was a way to reflect that we inverted a boolean. Like use an exclamation in the beginning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17864: Flip solr.hideStackTrace to .enabled equivalent. [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on code in PR #3503:
URL: https://github.com/apache/solr/pull/3503#discussion_r2296671793
##########
solr/core/src/java/org/apache/solr/core/NodeConfig.java:
##########
@@ -618,7 +618,8 @@ public static class NodeConfigBuilder {
private String defaultZkHost;
private Set<Path> allowPaths = Collections.emptySet();
private List<String> allowUrls = Collections.emptyList();
- private boolean hideStackTrace = Boolean.getBoolean("solr.hideStackTrace");
+ private boolean hideStackTrace =
+ !(Boolean.parseBoolean(System.getProperty("solr.responses.stacktrace.enabled", "true")));
Review Comment:
Sure!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org