[jira] [Commented] (LIBCLOUD-971) wait_until_running error when empty ip addresses

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LIBCLOUD-971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16298462#comment-16298462 ] 

ASF GitHub Bot commented on LIBCLOUD-971:
-----------------------------------------

GitHub user paepke opened a pull request:

    https://github.com/apache/libcloud/pull/1156

    LIBCLOUD-971 - wait_until_running should only append addresses if the

    ## LIBCLOUD-971 
    
    ### Description
    
     LIBCLOUD-971 - wait_until_running should only append ip addresses if the list is not empty.
    
    ### Status
    
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [X] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
    - [ ] Documentation
    - [X] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/paepke/libcloud LIBCLOUD-971

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1156.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1156
    
----
commit 933e3272a0db910bd97a55ce3d31c7cfbaa11347
Author: Tobias Paepke <to...@...>
Date:   2017-12-20T13:04:19Z

    LIBCLOUD-971 - wait_until_running should only append addresses if the
    list is not empty.

----


> wait_until_running error when empty ip addresses
> ------------------------------------------------
>
>                 Key: LIBCLOUD-971
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-971
>             Project: Libcloud
>          Issue Type: Bug
>          Components: Compute
>    Affects Versions: 0.13.3
>            Reporter: Tobias Paepke
>            Priority: Minor
>
> wait_until_running leads to an libcloud error if no valid ip address was provided by list_nodes. This happens in our setup especially if the node is running, but has no valid ip address assigned via dhcp.
> The function should retry to get a valid ip address until the timeout is reached.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)