[GitHub] [hadoop] arp7 commented on a change in pull request #724: HDDS-1376. Datanode exits while executing client command when scmId is null

[GitBox <gi...@apache.org>]

arp7 commented on a change in pull request #724: HDDS-1376. Datanode exits while executing client command when scmId is null
URL: https://github.com/apache/hadoop/pull/724#discussion_r274226324
 
 

 ##########
 File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/states/endpoint/VersionEndpointTask.java
 ##########
 @@ -106,7 +106,8 @@ public VersionEndpointTask(EndpointStateMachine rpcEndPoint,
           volumeSet.writeUnlock();
         }
 
-        ozoneContainer.getDispatcher().setScmId(scmId);
+        // Start the container services after getting the version information
+        ozoneContainer.start(scmId);
 
 Review comment:
   How does the fix work? I don't understand this startup sequence well enough to figure it out.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org