You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/01/21 22:25:46 UTC

[GitHub] [iceberg] rdblue commented on a change in pull request #3949: Spark 3.2: Revise distribution and ordering in copy-on-write UPDATE

rdblue commented on a change in pull request #3949:
URL: https://github.com/apache/iceberg/pull/3949#discussion_r790034645



##########
File path: spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/SparkDistributionAndOrderingUtil.java
##########
@@ -84,14 +85,14 @@ public static Distribution buildRequiredDistribution(Table table, DistributionMo
 
   public static Distribution buildCopyOnWriteDistribution(Table table, Command command,
                                                           DistributionMode distributionMode) {
-    if (command == DELETE) {
-      return buildCopyOnWriteDeleteDistribution(table, distributionMode);
+    if (command == DELETE || command == UPDATE) {

Review comment:
       Yeah, after looking at this I think I agree.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org