You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampipes.apache.org by GitBox <gi...@apache.org> on 2023/01/05 08:10:15 UTC

[GitHub] [streampipes] tenthe opened a new issue, #1036: Remove legacy classes in `streampipes-rest-shared`

tenthe opened a new issue, #1036:
URL: https://github.com/apache/streampipes/issues/1036

   ### Body
   
   Clean up module `streampipes-rest-shared`.
   - The interface `NoAuthenticationRequired` does not seem to be used anywhere. Can we remove it?
   - Tha package `.api` contains one interface `CRUDResource` that is not used anywhere. Can we remove it?
   - Class `SpMediaType` 
     - Contains the type `JSONLD`, can we remove this? It is only used in one API and I guess that is legacy code that we do not need anymore.
     - Then this class will only contain one variable `APPLICATION_ZIP` that is used. Can we move this to remove the class?
   
   In general this seems to be a rather small module. Can we move the packages to somewhere else or should we wait till we start refactor the REST API modules?
   
   ### StreamPipes Committer
   
   I acknowledge that I am a maintainer/committer of the Apache StreamPipes project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [streampipes] tenthe commented on issue #1036: Remove legacy classes in `streampipes-rest-shared`

Posted by GitBox <gi...@apache.org>.
tenthe commented on issue #1036:
URL: https://github.com/apache/streampipes/issues/1036#issuecomment-1371901198

   @dominikriemer what is your opinion on this issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [streampipes] dominikriemer commented on issue #1036: Remove legacy classes in `streampipes-rest-shared`

Posted by GitBox <gi...@apache.org>.
dominikriemer commented on issue #1036:
URL: https://github.com/apache/streampipes/issues/1036#issuecomment-1372841273

   The unused interface, `CRUDResource` and `JSONLD` media type can be removed from my point of view!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org