You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2013/11/01 19:41:17 UTC

svn commit: r1538019 - /commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/FormatCompliance.java

Author: ggregory
Date: Fri Nov  1 18:41:16 2013
New Revision: 1538019

URL: http://svn.apache.org/r1538019
Log:
Statement unnecessarily nested within else clause.

Modified:
    commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/FormatCompliance.java

Modified: commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/FormatCompliance.java
URL: http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/FormatCompliance.java?rev=1538019&r1=1538018&r2=1538019&view=diff
==============================================================================
--- commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/FormatCompliance.java (original)
+++ commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/FormatCompliance.java Fri Nov  1 18:41:16 2013
@@ -95,17 +95,16 @@ public class FormatCompliance {
             addComment(name + ": " + "Unexpected length: (expected: "
                     + expected.length + ", actual: " + actual.length + ")");
             return false;
-        } else {
-            for (int i = 0; i < expected.length; i++) {
-                // System.out.println("expected: "
-                // + getValueDescription(expected[i]) + ", actual: "
-                // + getValueDescription(actual[i]) + ")");
-                if (expected[i] != actual[i]) {
-                    addComment(name + ": " + "Unexpected value: (expected: "
-                            + getValueDescription(expected[i]) + ", actual: "
-                            + getValueDescription(actual[i]) + ")");
-                    return false;
-                }
+        }
+        for (int i = 0; i < expected.length; i++) {
+            // System.out.println("expected: "
+            // + getValueDescription(expected[i]) + ", actual: "
+            // + getValueDescription(actual[i]) + ")");
+            if (expected[i] != actual[i]) {
+                addComment(name + ": " + "Unexpected value: (expected: "
+                        + getValueDescription(expected[i]) + ", actual: "
+                        + getValueDescription(actual[i]) + ")");
+                return false;
             }
         }