You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/08/08 02:28:22 UTC
Review Request 13396: Fixed session handling on OS X.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13396/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Repository: mesos-git
Description
-------
This change makes Process::session an option in order to compensate for the fact that on OS X, getsid() does not work for zombie processes.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 448739e313bf5127e7e5469dd4090445dc5c5405
3rdparty/libprocess/3rdparty/stout/include/stout/os/killtree.hpp 9dc314c17c5ca3abc453fa4234d971f53acd60d6
3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp 4161e77ae9315029046634bd2233a258aa84e1f7
3rdparty/libprocess/3rdparty/stout/include/stout/os/process.hpp 9dbb89fff16cf688e7f9acd12c70021f6c8ca3a0
3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp f926056239b9cd86041e497c7c3b8eadc45f44c0
Diff: https://reviews.apache.org/r/13396/diff/
Testing
-------
make check on OS X (was broken and this fixed the issues)
Thanks,
Ben Mahler
Re: Review Request 13396: Fixed session handling on OS X.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13396/#review24852
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp
<https://reviews.apache.org/r/13396/#comment49030>
I think it would be clearer if we just kept the 'group && session', just 'group', just 'session'.
- Benjamin Hindman
On Aug. 8, 2013, 12:28 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13396/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2013, 12:28 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This change makes Process::session an option in order to compensate for the fact that on OS X, getsid() does not work for zombie processes.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 448739e313bf5127e7e5469dd4090445dc5c5405
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/killtree.hpp 9dc314c17c5ca3abc453fa4234d971f53acd60d6
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp 4161e77ae9315029046634bd2233a258aa84e1f7
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/process.hpp 9dbb89fff16cf688e7f9acd12c70021f6c8ca3a0
> 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp f926056239b9cd86041e497c7c3b8eadc45f44c0
>
> Diff: https://reviews.apache.org/r/13396/diff/
>
>
> Testing
> -------
>
> make check on OS X (was broken and this fixed the issues)
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 13396: Fixed session handling on OS X.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13396/
-----------------------------------------------------------
(Updated Aug. 10, 2013, 12:30 a.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Added a comment in killtree.
Repository: mesos-git
Description
-------
This change makes Process::session an option in order to compensate for the fact that on OS X, getsid() does not work for zombie processes.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/Makefile.am 770378d11d30e1e222e418c1839affd9d4ffe8d3
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 448739e313bf5127e7e5469dd4090445dc5c5405
3rdparty/libprocess/3rdparty/stout/include/stout/os/killtree.hpp 9dc314c17c5ca3abc453fa4234d971f53acd60d6
3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp 4161e77ae9315029046634bd2233a258aa84e1f7
3rdparty/libprocess/3rdparty/stout/include/stout/os/process.hpp 9dbb89fff16cf688e7f9acd12c70021f6c8ca3a0
3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp PRE-CREATION
3rdparty/libprocess/3rdparty/stout/include/stout/proc.hpp d51aaa97e90377c7ee0f3c68af4be295ce5f70f8
3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp f926056239b9cd86041e497c7c3b8eadc45f44c0
src/master/http.cpp ca66d6782023d303c8acc89ef9cf421cfca8d0dc
src/tests/reaper_tests.cpp d3e11072d5e8f5138210db566eec2d65942bcacd
Diff: https://reviews.apache.org/r/13396/diff/
Testing
-------
make check on OS X (was broken and this fixed the issues)
Thanks,
Ben Mahler
Re: Review Request 13396: Fixed session handling on OS X.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13396/
-----------------------------------------------------------
(Updated Aug. 8, 2013, 5:47 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Updated the logic for group / session intersection in os::pids per benh.
Repository: mesos-git
Description
-------
This change makes Process::session an option in order to compensate for the fact that on OS X, getsid() does not work for zombie processes.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 448739e313bf5127e7e5469dd4090445dc5c5405
3rdparty/libprocess/3rdparty/stout/include/stout/os/killtree.hpp 9dc314c17c5ca3abc453fa4234d971f53acd60d6
3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp 4161e77ae9315029046634bd2233a258aa84e1f7
3rdparty/libprocess/3rdparty/stout/include/stout/os/process.hpp 9dbb89fff16cf688e7f9acd12c70021f6c8ca3a0
3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp f926056239b9cd86041e497c7c3b8eadc45f44c0
Diff: https://reviews.apache.org/r/13396/diff/
Testing
-------
make check on OS X (was broken and this fixed the issues)
Thanks,
Ben Mahler