You are viewing a plain text version of this content. The canonical link for it is here.

Posted to codereview@trafodion.apache.org by xwq <gi...@git.apache.org> on 2015/12/01 03:33:33 UTC

[GitHub] incubator-trafodion pull request: [TRAFODION-1558]Tableau returns ...

Github user xwq commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/192#discussion_r46234065
  
    --- Diff: win-odbc64/odbcclient/drvr35/cstmt.cpp ---
    @@ -3389,7 +3389,7 @@ BOOL CStmt::setFetchOutputPerf(long rowsFetched, SQL_DataValue_def*& outputDataV
         m_FetchDataValue.numberOfRows = rowsFetched;
         if(rowsFetched > 0)
         {
    -        m_FetchDataValue.rowAddress = new unsigned long[rowsFetched];
    +        m_FetchDataValue.rowAddress = new LONG_PTR[rowsFetched];
    --- End diff --
    
    The issue here is that the long is 4 bytes in Windows x64.  windows can ensure the LONG_PTR is 8 bytes in x64 system and 4 bytes in x32 system. I use LONG_PTR because of a lot Windows API use it . There is no VOID_PTR type.
    I can use (void *) instead if you insist .


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---