You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/05/15 14:29:08 UTC

[GitHub] [skywalking] wu-sheng commented on pull request #4791: fix: fix double-checked locking bug

wu-sheng commented on pull request #4791:
URL: https://github.com/apache/skywalking/pull/4791#issuecomment-629266871


   First, this class in practice, actually wouldn't be initialized concurrently, because of the pre-main.
   
   Then, if you want to fix from the code review perspective, I prefer you to choose `With inner static holder` solution. 
   
   What would you say?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org