[GitHub] [inlong] dockerzhang commented on a diff in pull request #5189: [INLONG-5163][DataProxy] Fixing Pulsar clients initialization error

[GitBox <gi...@apache.org>]

dockerzhang commented on code in PR #5189:
URL: https://github.com/apache/inlong/pull/5189#discussion_r928220522


##########
inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/sink/pulsar/PulsarClientService.java:
##########
@@ -132,8 +132,9 @@ public void setConfigLogMetric(StreamConfigLogMetric streamConfigLogMetric) {
     }
 
     public void initCreateConnection(CreatePulsarClientCallBack callBack) {
+        pulsarUrl2token = ConfigManager.getInstance().getMqClusterUrl2Token();
         if (pulsarUrl2token == null || pulsarUrl2token.isEmpty()) {
-            logger.warn("failed to get Pulsar Cluster, make sure register pulsar to manager successfully.");
+            logger.warn("no pulsar cluster urls on startup, new deployment or cluster not registered properly");

Review Comment:
   the translation is not very accurate



##########
inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/sink/pulsar/PulsarClientService.java:
##########
@@ -283,9 +284,9 @@ private void sendResponse(OrderEvent orderEvent, String inlongGroupId, String in
      */
     private void createConnection(CreatePulsarClientCallBack callBack) throws FlumeException {
         if (!pulsarClients.isEmpty()) {
+            logger.info("pulsar clients may already be initialized by config updating thread");

Review Comment:
   this line may be needless, and I think we should remove it to avoid too logs if `pulsarClients` is not empty.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org