You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/04/10 08:26:20 UTC
[GitHub] [mynewt-mcumgr] de-nordic opened a new pull request #77: zephyr:
Convert k_timer calls to new API
de-nordic opened a new pull request #77: zephyr: Convert k_timer calls to new API
URL: https://github.com/apache/mynewt-mcumgr/pull/77
The new API does not accept integer types for timeouts, instead it uses
k_timeout_t structure.
Signed-off-by: Dominik Ermel <do...@nordicsemi.no>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-mcumgr] de-nordic commented on issue #77: zephyr: Convert
k_timer calls to new API
Posted by GitBox <gi...@apache.org>.
de-nordic commented on issue #77: zephyr: Convert k_timer calls to new API
URL: https://github.com/apache/mynewt-mcumgr/pull/77#issuecomment-613455448
Thanks for reviews and merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-mcumgr] carlescufi commented on a change in pull request
#77: zephyr: Convert k_timer calls to new API
Posted by GitBox <gi...@apache.org>.
carlescufi commented on a change in pull request #77: zephyr: Convert k_timer calls to new API
URL: https://github.com/apache/mynewt-mcumgr/pull/77#discussion_r406742802
##########
File path: cmd/os_mgmt/port/zephyr/src/zephyr_os_mgmt.c
##########
@@ -91,6 +91,6 @@ zephyr_os_mgmt_reset_cb(struct k_timer *timer)
int
os_mgmt_impl_reset(unsigned int delay_ms)
{
- k_timer_start(&zephyr_os_mgmt_reset_timer, K_MSEC(delay_ms), 0);
+ k_timer_start(&zephyr_os_mgmt_reset_timer, K_MSEC(delay_ms), K_MSEC(0));
Review comment:
Indeed, please use `K_NO_WAIT` just like the other users int he tree (there seems to be a couple of odd ones out, I will send a PR to correct the doc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-mcumgr] de-nordic commented on a change in pull request
#77: zephyr: Convert k_timer calls to new API
Posted by GitBox <gi...@apache.org>.
de-nordic commented on a change in pull request #77: zephyr: Convert k_timer calls to new API
URL: https://github.com/apache/mynewt-mcumgr/pull/77#discussion_r406823020
##########
File path: cmd/os_mgmt/port/zephyr/src/zephyr_os_mgmt.c
##########
@@ -91,6 +91,6 @@ zephyr_os_mgmt_reset_cb(struct k_timer *timer)
int
os_mgmt_impl_reset(unsigned int delay_ms)
{
- k_timer_start(&zephyr_os_mgmt_reset_timer, K_MSEC(delay_ms), 0);
+ k_timer_start(&zephyr_os_mgmt_reset_timer, K_MSEC(delay_ms), K_MSEC(0));
Review comment:
ok, done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-mcumgr] nvlsianpu commented on a change in pull request
#77: zephyr: Convert k_timer calls to new API
Posted by GitBox <gi...@apache.org>.
nvlsianpu commented on a change in pull request #77: zephyr: Convert k_timer calls to new API
URL: https://github.com/apache/mynewt-mcumgr/pull/77#discussion_r408056661
##########
File path: cmd/os_mgmt/port/zephyr/src/zephyr_os_mgmt.c
##########
@@ -34,6 +34,8 @@ static K_TIMER_DEFINE(zephyr_os_mgmt_reset_timer,
K_WORK_DEFINE(zephyr_os_mgmt_reset_work, zephyr_os_mgmt_reset_work_handler);
+
Review comment:
accidental new lines?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-mcumgr] de-nordic commented on a change in pull request
#77: zephyr: Convert k_timer calls to new API
Posted by GitBox <gi...@apache.org>.
de-nordic commented on a change in pull request #77: zephyr: Convert k_timer calls to new API
URL: https://github.com/apache/mynewt-mcumgr/pull/77#discussion_r408059921
##########
File path: cmd/os_mgmt/port/zephyr/src/zephyr_os_mgmt.c
##########
@@ -34,6 +34,8 @@ static K_TIMER_DEFINE(zephyr_os_mgmt_reset_timer,
K_WORK_DEFINE(zephyr_os_mgmt_reset_work, zephyr_os_mgmt_reset_work_handler);
+
Review comment:
I do not know where that came from :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-mcumgr] de-nordic commented on issue #77: zephyr: Convert
k_timer calls to new API
Posted by GitBox <gi...@apache.org>.
de-nordic commented on issue #77: zephyr: Convert k_timer calls to new API
URL: https://github.com/apache/mynewt-mcumgr/pull/77#issuecomment-611947956
Please review @carlescufi , @ccollins476ad
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-mcumgr] pabigot commented on a change in pull request #77:
zephyr: Convert k_timer calls to new API
Posted by GitBox <gi...@apache.org>.
pabigot commented on a change in pull request #77: zephyr: Convert k_timer calls to new API
URL: https://github.com/apache/mynewt-mcumgr/pull/77#discussion_r406715587
##########
File path: cmd/os_mgmt/port/zephyr/src/zephyr_os_mgmt.c
##########
@@ -91,6 +91,6 @@ zephyr_os_mgmt_reset_cb(struct k_timer *timer)
int
os_mgmt_impl_reset(unsigned int delay_ms)
{
- k_timer_start(&zephyr_os_mgmt_reset_timer, K_MSEC(delay_ms), 0);
+ k_timer_start(&zephyr_os_mgmt_reset_timer, K_MSEC(delay_ms), K_MSEC(0));
Review comment:
I believe the standard spelling when specifying no repeat interval is `K_NO_WAIT`. The value may not be the same as as `K_MSEC(0)` as it was when integer values were used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-mcumgr] vrahane merged pull request #77: zephyr: Convert
k_timer calls to new API
Posted by GitBox <gi...@apache.org>.
vrahane merged pull request #77: zephyr: Convert k_timer calls to new API
URL: https://github.com/apache/mynewt-mcumgr/pull/77
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services