You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "chenwang-databricks (via GitHub)" <gi...@apache.org> on 2026/04/21 13:49:48 UTC
[PR] [SPARK-XXXXX][SQL][Metric View] Extend V2 TableInfo for view definitions and dependencies [spark]
chenwang-databricks opened a new pull request, #55449:
URL: https://github.com/apache/spark/pull/55449
### What changes were proposed in this pull request?
This PR extends the V2 catalog API surface to carry view-style metadata that the upcoming metric view V2-catalog support needs:
- New `Dependency` interface with two implementations, `TableDependency` and `FunctionDependency`, plus a `DependencyList` record. They model a SQL object's dependencies in a structured way.
- `TableInfo`: add three optional fields plumbed through the existing `TableInfo.Builder` API:
- `tableType` (String) — e.g. "MANAGED", "EXTERNAL", "METRIC_VIEW".
- `viewDefinition` (String) — the view body (YAML for metric views, SQL for views).
- `viewDependencies` (`DependencyList`) — explicit list of source objects this view depends on.
- `TableSummary`: add the `METRIC_VIEW_TABLE_TYPE = "METRIC_VIEW"` constant alongside the existing `MANAGED_TABLE_TYPE` / `EXTERNAL_TABLE_TYPE` / `VIEW_TABLE_TYPE` / `FOREIGN_TABLE_TYPE`.
- `DelegatingCatalogExtension`: forward the `createTable(Identifier, TableInfo)` overload to the delegate so that catalogs wrapping a real `TableCatalog` (e.g. via Delta) propagate the new fields instead of silently dropping them.
### Why are the changes needed?
Today the V2 catalog API can describe a table's columns, properties, partitions and constraints, but not its view definition or dependency graph. The metric view feature [SPARK-54119](https://issues.apache.org/jira/browse/SPARK-54119) needs both: when CREATE VIEW WITH METRICS targets a non-session V2 catalog, the connector must be able to persist the YAML body and the list of source tables so that the metric view can be reloaded and re-analyzed later. This PR is the foundational API change; the behavior change (CREATE/DROP routing on V2 catalogs) lands in follow-up PRs.
### Does this PR introduce _any_ user-facing change?
No. The new fields on `TableInfo` are optional and default to null; existing connectors that ignore them continue to work unchanged. The `DelegatingCatalogExtension` change is a bug fix for the V2 API contract: the default `TableCatalog#createTable(Identifier, TableInfo)` in the base interface dropped these fields, so without this change catalogs that delegate (such as Delta wrapping another `TableCatalog`) would silently lose any caller-provided `tableType`/`viewDefinition`/ `viewDependencies`.
### How was this patch tested?
No new tests in this PR; the new API is exercised by the follow-up PRs (`MetricViewV2CatalogSuite`). Existing catalyst tests pass.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Cursor (Claude)
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as new features, bug fixes, or other behavior changes. Documentation-only updates are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54119][SQL] Extend V2 TableInfo for view definitions and dependencies [spark]
Posted by "chenwang-databricks (via GitHub)" <gi...@apache.org>.
chenwang-databricks closed pull request #55449: [SPARK-54119][SQL] Extend V2 TableInfo for view definitions and dependencies
URL: https://github.com/apache/spark/pull/55449
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org