[jira] [Comment Edited] (JCRVLT-542) FolderArtifactHandler not respecting ImportMode on adjusting primaryTypes

["Dominik Süß (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCRVLT-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17369530#comment-17369530 ] 

Dominik Süß edited comment on JCRVLT-542 at 6/25/21, 3:14 PM:
--------------------------------------------------------------

Correct - I'm also not sure if the way the nodetype is adjusted is correctly reflected in the log/ status output. "normal" changes return corresponding entries but this adjustment seems to be silent and is not reflected in the tracker (which seems to be cosmetic but still makes debugging way harder)


was (Author: dsuess):
Correct - I'm also not sure if the way the nodetype is adjusted is correctly reflected in the log/ status output. "normal" changes return corresponding entries but this adjustment seems to be silent and is not reflected in the tracker.

> FolderArtifactHandler not respecting ImportMode on adjusting primaryTypes
> -------------------------------------------------------------------------
>
>                 Key: JCRVLT-542
>                 URL: https://issues.apache.org/jira/browse/JCRVLT-542
>             Project: Jackrabbit FileVault
>          Issue Type: Bug
>          Components: vlt
>    Affects Versions: 3.4.4
>            Reporter: Dominik Süß
>            Assignee: Konrad Windszus
>            Priority: Critical
>             Fix For: 3.5.2
>
>
> By definition mode=merge or the new mode=merge_properties should never modify existing nodes/properties for the corresponding filters. It turns out that this check is  missing for the adjustments of primaryNodeTypes which boldly breaks where the parent structures are assumed to be preexisting (like /home/groups) and just covered by folders without any nodetype declared - the existing logic does reset those to the default nt:folder which leads to a broken commit due to nodeType incompatibilities.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)