You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/12/15 07:59:17 UTC
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request #523: nshlib: Remove fdopen for the stdin, stdout and stderr
xiaoxiang781216 opened a new pull request #523:
URL: https://github.com/apache/incubator-nuttx-apps/pull/523
## Summary
not really need since these file stream should be opened automatically.
Need work with https://github.com/apache/incubator-nuttx/pull/2540.
See the discussion here: #521
## Impact
Handle the usb console in a more standardized way
## Testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #523: nshlib: Remove fdopen for the stdin, stdout and stderr
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #523:
URL: https://github.com/apache/incubator-nuttx-apps/pull/523#issuecomment-745123592
@masayuki2009 and @michallenc could you try the new approach as suggested by @patacongo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] michallenc commented on pull request #523: nshlib: Remove fdopen for the stdin, stdout and stderr
Posted by GitBox <gi...@apache.org>.
michallenc commented on pull request #523:
URL: https://github.com/apache/incubator-nuttx-apps/pull/523#issuecomment-745432011
> @masayuki2009 and @michallenc could you try the new approach as suggested by @patacongo.
@xiaoxiang781216 USB console on Teensy-4.x works with the changes you made.
```
NuttShell (NSH) NuttX-9.1.1
nsh>
nsh>
nsh> ls dev
/dev:
console
null
ttyACM0
ttyS0
nsh>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] masayuki2009 commented on pull request #523: nshlib: Remove fdopen for the stdin, stdout and stderr
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #523:
URL: https://github.com/apache/incubator-nuttx-apps/pull/523#issuecomment-745617332
> @masayuki2009 and @michallenc could you try the new approach as suggested by @patacongo.
@xiaoxiang781216
The new PRs works with stm32f4discovery:usbnsh
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] masayuki2009 merged pull request #523: nshlib: Remove fdopen for the stdin, stdout and stderr
Posted by GitBox <gi...@apache.org>.
masayuki2009 merged pull request #523:
URL: https://github.com/apache/incubator-nuttx-apps/pull/523
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org