You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@rocketmq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/09 04:51:05 UTC

[jira] [Commented] (ROCKETMQ-188) RemotingExecption is not consistent between invoke async and invoke oneway

    [ https://issues.apache.org/jira/browse/ROCKETMQ-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16002020#comment-16002020 ] 

ASF GitHub Bot commented on ROCKETMQ-188:
-----------------------------------------

Github user Jaskey commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/98
  
    @lizhanhui @zhouxinyu @shroman 
    guys, anyone helps review this pr?


> RemotingExecption is not consistent between invoke async and invoke oneway
> --------------------------------------------------------------------------
>
>                 Key: ROCKETMQ-188
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-188
>             Project: Apache RocketMQ
>          Issue Type: Bug
>          Components: rocketmq-remoting
>            Reporter: Jaskey Lam
>            Assignee: Jaskey Lam
>            Priority: Minor
>
> For existing invoke oneway code base, RemotingTooMuchRequestException will be thrown only when timeout millis <0, otherwise, RemotingTimeoutException will be thrown.
> But in invokeAsync, RemotingTooMuchRequestException is always thrown no matter what value the timeout millis , which is inconsistent. Besides, the RemotingTimeoutException is declared in the signature but it will be never thrown.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)