You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/09/08 21:19:53 UTC

[GitHub] [geode] gesterzhou commented on a change in pull request #5486: DRAFT: Do not store dropped events in stopped primary gateway sender when po…

gesterzhou commented on a change in pull request #5486:
URL: https://github.com/apache/geode/pull/5486#discussion_r485202246



##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySender.java
##########
@@ -1034,10 +1034,7 @@ public void distribute(EnumListenerEvent operation, EntryEventImpl event,
       // If this gateway is not running, return
       if (!isRunning()) {
         if (this.isPrimary()) {
-          tmpDroppedEvents.add(clonedEvent);
-          if (isDebugEnabled) {
-            logger.debug("add to tmpDroppedEvents for evnet {}", clonedEvent);
-          }
+          dropEvent(clonedEvent);

Review comment:
       this should be recordDroppedEvent or similar name. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org