You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jeff Zhang (JIRA)" <ji...@apache.org> on 2010/10/25 08:33:18 UTC
[jira] Created: (HBASE-3148) Duplicate check table name in
HBaseAdmin's createTable method
Duplicate check table name in HBaseAdmin's createTable method
-------------------------------------------------------------
Key: HBASE-3148
URL: https://issues.apache.org/jira/browse/HBASE-3148
Project: HBase
Issue Type: Improvement
Components: client
Reporter: Jeff Zhang
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Commented] (HBASE-3148) Duplicate check table name in
HBaseAdmin's createTable method
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029178#comment-13029178 ]
stack commented on HBASE-3148:
------------------------------
I agree. There are actually more than one redundant calls to isLegalTableName done in a single code path. Do you have a patch to fix it?
> Duplicate check table name in HBaseAdmin's createTable method
> -------------------------------------------------------------
>
> Key: HBASE-3148
> URL: https://issues.apache.org/jira/browse/HBASE-3148
> Project: HBase
> Issue Type: Improvement
> Components: client
> Reporter: Jeff Zhang
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HBASE-3148) Duplicate check table name in
HBaseAdmin's createTable method
Posted by "Jeff Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924456#action_12924456 ]
Jeff Zhang commented on HBASE-3148:
-----------------------------------
When I learn the hbase code, I found that there's a duplicate check table name in HBaseAdmin's createTable method.
Line 282 in createTable method do one check and line 332 do another check in createTableAsync which is called by createTable. I believe one check can been removed.
> Duplicate check table name in HBaseAdmin's createTable method
> -------------------------------------------------------------
>
> Key: HBASE-3148
> URL: https://issues.apache.org/jira/browse/HBASE-3148
> Project: HBase
> Issue Type: Improvement
> Components: client
> Reporter: Jeff Zhang
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.