[GitHub] [fineract] galovics commented on a diff in pull request #2820: FINERACT-1838: Loan account external events with repayment schedule

[GitBox <gi...@apache.org>]

galovics commented on code in PR #2820:
URL: https://github.com/apache/fineract/pull/2820#discussion_r1051179269


##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/event/external/service/serialization/serializer/loan/LoanBusinessEventSerializer.java:
##########
@@ -46,6 +46,7 @@ public <T> boolean canSerialize(BusinessEvent<T> event) {
     protected <T> ByteBufferSerializable toAvroDTO(BusinessEvent<T> rawEvent) {
         LoanBusinessEvent event = (LoanBusinessEvent) rawEvent;
         LoanAccountData data = service.retrieveOne(event.get().getId());
+        data = service.fetchRepaymentScheduleData(data);

Review Comment:
   @josehernandezfintecheandomx do you think we can get this data with the retrieveOne call directly (so like extending the native query)? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org