[GitHub] [spark] wangyum commented on a change in pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver

[GitBox <gi...@apache.org>]

wangyum commented on a change in pull request #29933:
URL: https://github.com/apache/spark/pull/29933#discussion_r503614378



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -893,6 +893,16 @@ object SQLConf {
       .booleanConf
       .createWithDefault(false)
 
+  val THRIFTSERVER_QUERY_TIMEOUT =
+    buildConf("spark.sql.thriftServer.queryTimeout")
+      .doc("Specifies a global timeout value for Thrift Server. A query will be cancelled " +
+        "automatically after the specified time. If a timeout value is set for each statement " +
+        "(e.g., via `java.sql.Statement.setQueryTimeout`), the value takes precedence. " +
+        "If the value is zero or negative, no timeout happens.")

Review comment:
       Could we add time unit to doc? e.g., 'Timeout in seconds ...'




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org