You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/09/08 22:23:00 UTC
[GitHub] [arrow] kou commented on a diff in pull request #37637: GH-37636: [Go] Bump minimum go versions
kou commented on code in PR #37637:
URL: https://github.com/apache/arrow/pull/37637#discussion_r1320386338
##########
.github/workflows/go.yml:
##########
@@ -430,11 +430,11 @@ jobs:
- name: Install go
uses: actions/setup-go@v4
with:
- go-version: '1.18'
+ go-version: '1.19'
cache: true
cache-dependency-path: go/go.sum
- name: Install staticcheck
- run: go install honnef.co/go/tools/cmd/staticcheck@v0.3.3
+ run: go install honnef.co/go/tools/cmd/staticcheck@v0.4.5
Review Comment:
Can we read staticcheck version from `.env`?
```diff
diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml
index c31ad0b77..ba059817d 100644
--- a/.github/workflows/go.yml
+++ b/.github/workflows/go.yml
@@ -434,7 +434,10 @@ jobs:
cache: true
cache-dependency-path: go/go.sum
- name: Install staticcheck
- run: go install honnef.co/go/tools/cmd/staticcheck@v0.3.3
+ shell: bash
+ run: |
+ . .env
+ go install honnef.co/go/tools/cmd/staticcheck@${STATICCHECK}
- name: Build
shell: bash
run: ci/scripts/go_build.sh $(pwd)
```
##########
.github/workflows/go.yml:
##########
@@ -54,23 +54,23 @@ jobs:
include:
- arch-label: AMD64
arch: amd64
- go: 1.17
+ go: 1.19
runs-on: ubuntu-latest
- staticcheck: v0.2.2
+ staticcheck: v0.4.5
Review Comment:
It seems that we always use staticcheck v0.4.5. Can we remove this parameter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org