[GitHub] [solr] dsmiley commented on a diff in pull request #1108: SOLR-14251 Add option skipFreeSpaceCheck to split shard operation

[GitBox <gi...@apache.org>]

dsmiley commented on code in PR #1108:
URL: https://github.com/apache/solr/pull/1108#discussion_r1002329395


##########
solr/core/src/java/org/apache/solr/cloud/api/collections/SplitShardCmd.java:
##########
@@ -199,8 +200,17 @@ public boolean split(ClusterState clusterState, ZkNodeProps message, NamedList<O
             "SplitShardCmd: verify that there is enough space on disk to create sub-shards for slice: {}",
             parentShardLeader);
         t = timings.sub("checkDiskSpace");
-        checkDiskSpace(
-            collectionName, slice.get(), parentShardLeader, splitMethod, ccc.getSolrCloudManager());
+        boolean skipFreeSpaceCheck = message.getBool(SKIP_FREE_SPACE_CHECK, false);

Review Comment:
   See the System.getProperty thing above?  Let's just combine this into one so that the system property is the default.
   CC @heythm 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org