You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/03/06 13:44:36 UTC

[GitHub] [apisix-ingress-controller] stu01509 opened a new pull request #283: docs: update deployments repository url

stu01509 opened a new pull request #283:
URL: https://github.com/apache/apisix-ingress-controller/pull/283


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [x] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   - Related issues #277 
   
   ___
   ### Bugfix
   - Description
   Update deployment docs repository url.
   
   - How to fix?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #283: docs: update deployments repository url

Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #283:
URL: https://github.com/apache/apisix-ingress-controller/pull/283#discussion_r593155720



##########
File path: docs/en/latest/deployments/aws.md
##########
@@ -38,7 +38,9 @@ This document explains how to install Ingress APISIX on [Amazon EKS](https://ama
 ```shell
 cd /path/to/apisix-helm-chart
 helm repo add bitnami https://charts.bitnami.com/bitnami
-helm dependency update ./charts/apisix
+helm repo add apisix https://charts.apiseven.com
+# Use `hem search repo apisix` to search charts about apisix
+helm repo update
 helm install apisix ./charts/apisix \

Review comment:
       We don't need to use local chart as we use the online repo already.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #283: docs: update deployments repository url

Posted by GitBox <gi...@apache.org>.
gxthrj commented on pull request #283:
URL: https://github.com/apache/apisix-ingress-controller/pull/283#issuecomment-797261594


   Any update? @stu01509 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #283: docs: update deployments repository url

Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #283:
URL: https://github.com/apache/apisix-ingress-controller/pull/283#discussion_r589117700



##########
File path: docs/en/latest/deployments/ack.md
##########
@@ -38,6 +38,8 @@ This document explains how to install Ingress APISIX on [ali-cloud ACK](https://
 ```shell
 cd /path/to/apisix-helm-chart
 helm repo add bitnami https://charts.bitnami.com/bitnami
+helm repo add apisix https://charts.apiseven.com
+# Use `hem search repo apisix` to search charts about apisix
 helm dependency update ./charts/apisix
 helm install apisix ./charts/apisix \

Review comment:
       Try this :), and we suggest you to run it locally
   ```suggestion
   cd /path/to/apisix-helm-chart
   helm repo add bitnami https://charts.bitnami.com/bitnami
   helm repo add apisix https://charts.apiseven.com
   # Use `hem search repo apisix` to search charts about apisix
   helm repo update
   helm install apisix apisix/apisix \
     --set gateway.type=LoadBalancer \
     --set allow.ipList="{0.0.0.0/0}" \
     --namespace ingress-apisix \
   kubectl get service --namespace ingress-apisix
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] membphis commented on pull request #283: docs: update deployments repository url

Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #283:
URL: https://github.com/apache/apisix-ingress-controller/pull/283#issuecomment-798924573


   ping @gxthrj 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on pull request #283: docs: update deployments repository url

Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #283:
URL: https://github.com/apache/apisix-ingress-controller/pull/283#issuecomment-797872426


   @stu01509 We should also change the way to install apisix-ingress-controller itself :).
   
   ![image](https://user-images.githubusercontent.com/10428333/111020636-5f622280-8402-11eb-8620-aad4342f5b80.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] stu01509 commented on a change in pull request #283: docs: update deployments repository url

Posted by GitBox <gi...@apache.org>.
stu01509 commented on a change in pull request #283:
URL: https://github.com/apache/apisix-ingress-controller/pull/283#discussion_r593573534



##########
File path: docs/en/latest/deployments/azure.md
##########
@@ -38,6 +38,8 @@ This document explains how to install Ingress APISIX on [Azure AKS](https://docs
 ```shell
 cd /path/to/apisix-helm-chart
 helm repo add bitnami https://charts.bitnami.com/bitnami
+helm repo add apisix https://charts.apiseven.com
+# Use `hem search repo apisix` to search charts about apisix
 helm dependency update ./charts/apisix
 helm install apisix ./charts/apisix \

Review comment:
       Update the commit.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #283: docs: update deployments repository url

Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #283:
URL: https://github.com/apache/apisix-ingress-controller/pull/283#discussion_r593552177



##########
File path: docs/en/latest/deployments/azure.md
##########
@@ -38,6 +38,8 @@ This document explains how to install Ingress APISIX on [Azure AKS](https://docs
 ```shell
 cd /path/to/apisix-helm-chart
 helm repo add bitnami https://charts.bitnami.com/bitnami
+helm repo add apisix https://charts.apiseven.com
+# Use `hem search repo apisix` to search charts about apisix
 helm dependency update ./charts/apisix
 helm install apisix ./charts/apisix \

Review comment:
       here should also be changed.

##########
File path: docs/en/latest/deployments/azure.md
##########
@@ -38,6 +38,8 @@ This document explains how to install Ingress APISIX on [Azure AKS](https://docs
 ```shell
 cd /path/to/apisix-helm-chart
 helm repo add bitnami https://charts.bitnami.com/bitnami
+helm repo add apisix https://charts.apiseven.com
+# Use `hem search repo apisix` to search charts about apisix
 helm dependency update ./charts/apisix
 helm install apisix ./charts/apisix \

Review comment:
       Also, the installation of apisix-ingress-controller should also change to use the online repo.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #283: docs: update deployments repository url

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #283:
URL: https://github.com/apache/apisix-ingress-controller/pull/283#issuecomment-791950589


   # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/283?src=pr&el=h1) Report
   > Merging [#283](https://codecov.io/gh/apache/apisix-ingress-controller/pull/283?src=pr&el=desc) (e43bf85) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/4e391e1c55fbc9e9a5a254b0352e9829e5823174?el=desc) (4e391e1) will **increase** coverage by `47.80%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/283/graphs/tree.svg?width=650&height=150&src=pr&token=WPLQXPY3V0)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/283?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##           master      #283       +/-   ##
   ============================================
   + Coverage   52.19%   100.00%   +47.80%     
   ============================================
     Files          33         1       -32     
     Lines        2320         1     -2319     
   ============================================
   - Hits         1211         1     -1210     
   + Misses        952         0      -952     
   + Partials      157         0      -157     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/283?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/283/diff?src=pr&el=tree#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | | |
   | [pkg/seven/state/solver.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/283/diff?src=pr&el=tree#diff-cGtnL3NldmVuL3N0YXRlL3NvbHZlci5nbw==) | | |
   | [pkg/kube/translation/annotations.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/283/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYW5ub3RhdGlvbnMuZ28=) | | |
   | [pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/283/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv) | | |
   | [pkg/kube/translation/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/283/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3JvdXRlLmdv) | | |
   | [pkg/log/options.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/283/diff?src=pr&el=tree#diff-cGtnL2xvZy9vcHRpb25zLmdv) | | |
   | [pkg/seven/conf/conf.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/283/diff?src=pr&el=tree#diff-cGtnL3NldmVuL2NvbmYvY29uZi5nbw==) | | |
   | [pkg/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/283/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9yb3V0ZS5nbw==) | | |
   | [pkg/seven/state/route\_worker.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/283/diff?src=pr&el=tree#diff-cGtnL3NldmVuL3N0YXRlL3JvdXRlX3dvcmtlci5nbw==) | | |
   | [pkg/api/router/router.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/283/diff?src=pr&el=tree#diff-cGtnL2FwaS9yb3V0ZXIvcm91dGVyLmdv) | | |
   | ... and [22 more](https://codecov.io/gh/apache/apisix-ingress-controller/pull/283/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/283?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/283?src=pr&el=footer). Last update [4e391e1...e43bf85](https://codecov.io/gh/apache/apisix-ingress-controller/pull/283?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #283: docs: update deployments repository url

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #283:
URL: https://github.com/apache/apisix-ingress-controller/pull/283#issuecomment-791950589


   # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/283?src=pr&el=h1) Report
   > Merging [#283](https://codecov.io/gh/apache/apisix-ingress-controller/pull/283?src=pr&el=desc) (5ffe86a) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/4e391e1c55fbc9e9a5a254b0352e9829e5823174?el=desc) (4e391e1) will **increase** coverage by `0.08%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/283/graphs/tree.svg?width=650&height=150&src=pr&token=WPLQXPY3V0)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/283?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #283      +/-   ##
   ==========================================
   + Coverage   52.19%   52.28%   +0.08%     
   ==========================================
     Files          33       32       -1     
     Lines        2320     2320              
   ==========================================
   + Hits         1211     1213       +2     
   + Misses        952      950       -2     
     Partials      157      157              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/283?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/283/diff?src=pr&el=tree#diff-dGVzdC9lMmUvZTJlLmdv) | | |
   | [pkg/apisix/ssl.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/283/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9zc2wuZ28=) | `39.86% <0.00%> (+0.40%)` | :arrow_up: |
   | [pkg/seven/state/solver.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/283/diff?src=pr&el=tree#diff-cGtnL3NldmVuL3N0YXRlL3NvbHZlci5nbw==) | `4.00% <0.00%> (+2.00%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/283?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/283?src=pr&el=footer). Last update [4e391e1...5ffe86a](https://codecov.io/gh/apache/apisix-ingress-controller/pull/283?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] gxthrj merged pull request #283: docs: update deployments repository url

Posted by GitBox <gi...@apache.org>.
gxthrj merged pull request #283:
URL: https://github.com/apache/apisix-ingress-controller/pull/283


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] stu01509 commented on pull request #283: docs: update deployments repository url

Posted by GitBox <gi...@apache.org>.
stu01509 commented on pull request #283:
URL: https://github.com/apache/apisix-ingress-controller/pull/283#issuecomment-797474690


   Hi @gxthrj and @tokers 
   
    Sorry for the late, I update the commit, please take a look.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #283: docs: update deployments repository url

Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #283:
URL: https://github.com/apache/apisix-ingress-controller/pull/283#discussion_r588975773



##########
File path: docs/en/latest/deployments/ack.md
##########
@@ -38,6 +38,8 @@ This document explains how to install Ingress APISIX on [ali-cloud ACK](https://
 ```shell
 cd /path/to/apisix-helm-chart
 helm repo add bitnami https://charts.bitnami.com/bitnami
+helm repo add apisix https://charts.apiseven.com
+# Use `hem search repo apisix` to search charts about apisix
 helm dependency update ./charts/apisix
 helm install apisix ./charts/apisix \

Review comment:
       This line should be change also.
   
   ```shell
   helm install apisix apisix/apisix
   ```
   
   That's why we should add a comment `# Use `hem search repo apisix` to search charts about apisix`, because the charts name `apisix/apisix` can be found from this command.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] stu01509 commented on a change in pull request #283: docs: update deployments repository url

Posted by GitBox <gi...@apache.org>.
stu01509 commented on a change in pull request #283:
URL: https://github.com/apache/apisix-ingress-controller/pull/283#discussion_r588996287



##########
File path: docs/en/latest/deployments/ack.md
##########
@@ -38,6 +38,8 @@ This document explains how to install Ingress APISIX on [ali-cloud ACK](https://
 ```shell
 cd /path/to/apisix-helm-chart
 helm repo add bitnami https://charts.bitnami.com/bitnami
+helm repo add apisix https://charts.apiseven.com
+# Use `hem search repo apisix` to search charts about apisix
 helm dependency update ./charts/apisix
 helm install apisix ./charts/apisix \

Review comment:
       Like tihs?
   
   ```shell
   cd /path/to/apisix-helm-chart
   helm repo add bitnami https://charts.bitnami.com/bitnami
   helm repo add apisix https://charts.apiseven.com
   # Use `hem search repo apisix` to search charts about apisix
   helm dependency update ./charts/apisix
   helm install apisix apisix/apisix \
     --set gateway.type=LoadBalancer \
     --set allow.ipList="{0.0.0.0/0}" \
     --namespace ingress-apisix \
   kubectl get service --namespace ingress-apisix
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org