You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "hailin0 (via GitHub)" <gi...@apache.org> on 2023/05/05 03:55:38 UTC
[GitHub] [incubator-seatunnel] hailin0 commented on a diff in pull request #4698: [Feature][Connector][Http] Support multi-line text splits
hailin0 commented on code in PR #4698:
URL: https://github.com/apache/incubator-seatunnel/pull/4698#discussion_r1185677197
##########
docs/en/connector-v2/source/Github.md:
##########
@@ -17,22 +17,23 @@ Used to read data from Github.
## Options
-| name | type | required | default value |
-|-----------------------------|--------|----------|---------------|
-| url | String | Yes | - |
-| access_token | String | No | - |
-| method | String | No | get |
-| schema.fields | Config | No | - |
-| format | String | No | json |
-| params | Map | No | - |
-| body | String | No | - |
-| json_field | Config | No | - |
-| content_json | String | No | - |
-| poll_interval_ms | int | No | - |
-| retry | int | No | - |
-| retry_backoff_multiplier_ms | int | No | 100 |
-| retry_backoff_max_ms | int | No | 10000 |
-| common-options | config | No | - |
+| name | type | required | default value |
+|-----------------------------|---------|----------|---------------|
+| url | String | Yes | - |
+| access_token | String | No | - |
+| method | String | No | get |
+| schema.fields | Config | No | - |
+| format | String | No | json |
+| params | Map | No | - |
+| body | String | No | - |
+| json_field | Config | No | - |
+| content_json | String | No | - |
+| poll_interval_ms | int | No | - |
+| retry | int | No | - |
+| retry_backoff_multiplier_ms | int | No | 100 |
+| retry_backoff_max_ms | int | No | 10000 |
+| common-options | config | No | - |
+| enableMultiLines | boolean | No | false |
Review Comment:
```suggestion
| enable_multi_lines | boolean | No | false |
| common-options | config | No | - |
```
##########
docs/en/connector-v2/source/Github.md:
##########
@@ -17,22 +17,23 @@ Used to read data from Github.
## Options
-| name | type | required | default value |
-|-----------------------------|--------|----------|---------------|
-| url | String | Yes | - |
-| access_token | String | No | - |
-| method | String | No | get |
-| schema.fields | Config | No | - |
-| format | String | No | json |
-| params | Map | No | - |
-| body | String | No | - |
-| json_field | Config | No | - |
-| content_json | String | No | - |
-| poll_interval_ms | int | No | - |
-| retry | int | No | - |
-| retry_backoff_multiplier_ms | int | No | 100 |
-| retry_backoff_max_ms | int | No | 10000 |
-| common-options | config | No | - |
+| name | type | required | default value |
+|-----------------------------|---------|----------|---------------|
+| url | String | Yes | - |
+| access_token | String | No | - |
+| method | String | No | get |
+| schema.fields | Config | No | - |
+| format | String | No | json |
+| params | Map | No | - |
+| body | String | No | - |
+| json_field | Config | No | - |
+| content_json | String | No | - |
+| poll_interval_ms | int | No | - |
+| retry | int | No | - |
+| retry_backoff_multiplier_ms | int | No | 100 |
+| retry_backoff_max_ms | int | No | 10000 |
+| common-options | config | No | - |
+| enableMultiLines | boolean | No | false |
Review Comment:
Update all this configuration item name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org