You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/12/04 21:07:35 UTC
[GitHub] [tvm-vta] dsteger opened a new pull request #20: Enable Supported Xilinx target ZCU104 with Hardware Preset
dsteger opened a new pull request #20:
URL: https://github.com/apache/tvm-vta/pull/20
This commit adds support for the Xilinx zcu104 development board.
Currently, TVM-VTA does not support a production board thus this
commit. Leveraging a supported board which is integrated into Vivado
provides board presets properly configuring peripherals and IO for
development. This means that the project can be used for further
bsp development using the XSA.
Also, enable fpga_board and fpga_board_ver properties for
Xilinx Platforms. This enables the hardware project to
produce a usable XSA which contains the board presets.
The board preset contains board specific config such as
IO/PS/DDR settings.
The end goal of this commit is to allow the output products
of TVM-VTA to be used in bsp creation and.. produce more
meaningful output products.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm-vta] liangfu commented on a change in pull request #20: Enable Supported Xilinx target ZCU104 with Hardware Preset
Posted by GitBox <gi...@apache.org>.
liangfu commented on a change in pull request #20:
URL: https://github.com/apache/tvm-vta/pull/20#discussion_r536612380
##########
File path: hardware/xilinx/scripts/vivado.tcl
##########
@@ -80,6 +82,11 @@ set store_ip "${ip_path}/vta_store/soln/impl/ip/xilinx_com_hls_store_1_0.zip"
# Create custom project
create_project -force $proj_name $proj_path -part $device
+# Apply board preset if exists
+if {$board != "None" && $board_rev != "None"} {
+ set_property BOARD_PART $board:$board_rev [current_project]
Review comment:
Just curious, why is BOARD_PART required here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm-vta] dsteger commented on a change in pull request #20: Enable Supported Xilinx target ZCU104 with Hardware Preset
Posted by GitBox <gi...@apache.org>.
dsteger commented on a change in pull request #20:
URL: https://github.com/apache/tvm-vta/pull/20#discussion_r537919215
##########
File path: hardware/xilinx/scripts/vivado.tcl
##########
@@ -80,6 +82,11 @@ set store_ip "${ip_path}/vta_store/soln/impl/ip/xilinx_com_hls_store_1_0.zip"
# Create custom project
create_project -force $proj_name $proj_path -part $device
+# Apply board preset if exists
+if {$board != "None" && $board_rev != "None"} {
+ set_property BOARD_PART $board:$board_rev [current_project]
Review comment:
@liangfu Let me know if you have any more questions. Would love to get this merged so I can submit the next PR to support the ultra96 variants. (v1 and v2 have different parts from a tools point of view - v2 is industrial grade).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm-vta] liangfu merged pull request #20: Enable Supported Xilinx target ZCU104 with Hardware Preset
Posted by GitBox <gi...@apache.org>.
liangfu merged pull request #20:
URL: https://github.com/apache/tvm-vta/pull/20
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm-vta] dsteger commented on a change in pull request #20: Enable Supported Xilinx target ZCU104 with Hardware Preset
Posted by GitBox <gi...@apache.org>.
dsteger commented on a change in pull request #20:
URL: https://github.com/apache/tvm-vta/pull/20#discussion_r537919215
##########
File path: hardware/xilinx/scripts/vivado.tcl
##########
@@ -80,6 +82,11 @@ set store_ip "${ip_path}/vta_store/soln/impl/ip/xilinx_com_hls_store_1_0.zip"
# Create custom project
create_project -force $proj_name $proj_path -part $device
+# Apply board preset if exists
+if {$board != "None" && $board_rev != "None"} {
+ set_property BOARD_PART $board:$board_rev [current_project]
Review comment:
@liangfu Let me know if you have any more questions. Would love to get this merged so I can submit the next PR to support the ultra96 variants. (v1 and v2 have different parts from a tools point of view - v2 is industrial grade).
##########
File path: hardware/xilinx/scripts/vivado.tcl
##########
@@ -80,6 +82,11 @@ set store_ip "${ip_path}/vta_store/soln/impl/ip/xilinx_com_hls_store_1_0.zip"
# Create custom project
create_project -force $proj_name $proj_path -part $device
+# Apply board preset if exists
+if {$board != "None" && $board_rev != "None"} {
+ set_property BOARD_PART $board:$board_rev [current_project]
Review comment:
AVNET has board files that can be used as external sources. Would be a good update for the Ultra96 hardware.
https://github.com/Avnet/bdf/tree/master/ultra96v2/1.1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm-vta] dsteger commented on a change in pull request #20: Enable Supported Xilinx target ZCU104 with Hardware Preset
Posted by GitBox <gi...@apache.org>.
dsteger commented on a change in pull request #20:
URL: https://github.com/apache/tvm-vta/pull/20#discussion_r537829814
##########
File path: hardware/xilinx/scripts/vivado.tcl
##########
@@ -80,6 +82,11 @@ set store_ip "${ip_path}/vta_store/soln/impl/ip/xilinx_com_hls_store_1_0.zip"
# Create custom project
create_project -force $proj_name $proj_path -part $device
+# Apply board preset if exists
+if {$board != "None" && $board_rev != "None"} {
+ set_property BOARD_PART $board:$board_rev [current_project]
Review comment:
When you build a hardware design Vivado let's you specify something called presets based on BOARD_PART. Presets are board specific configurations related to the hardware. Most importantly the DDR configuration. If you look at the hardware design built without a preset you will notice that the DDR defaults to 1600MHz. If you apply the preset (ZCU104 for this example) the DDR clock will be 2133MHZ.
If we want meaningful output products then we should specify this for the boards.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm-vta] liangfu commented on pull request #20: Enable Supported Xilinx target ZCU104 with Hardware Preset
Posted by GitBox <gi...@apache.org>.
liangfu commented on pull request #20:
URL: https://github.com/apache/tvm-vta/pull/20#issuecomment-742216383
Thanks @dsteger and @vegaluisjose for reviewing the changes. This is now merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm-vta] dsteger commented on pull request #20: Enable Supported Xilinx target ZCU104 with Hardware Preset
Posted by GitBox <gi...@apache.org>.
dsteger commented on pull request #20:
URL: https://github.com/apache/tvm-vta/pull/20#issuecomment-740216108
I just forced push a change to apply the preset. FYI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm-vta] dsteger commented on a change in pull request #20: Enable Supported Xilinx target ZCU104 with Hardware Preset
Posted by GitBox <gi...@apache.org>.
dsteger commented on a change in pull request #20:
URL: https://github.com/apache/tvm-vta/pull/20#discussion_r537844949
##########
File path: hardware/xilinx/scripts/vivado.tcl
##########
@@ -80,6 +82,11 @@ set store_ip "${ip_path}/vta_store/soln/impl/ip/xilinx_com_hls_store_1_0.zip"
# Create custom project
create_project -force $proj_name $proj_path -part $device
+# Apply board preset if exists
+if {$board != "None" && $board_rev != "None"} {
+ set_property BOARD_PART $board:$board_rev [current_project]
Review comment:
AVNET has board files that can be used as external sources. Would be a good update for the Ultra96 hardware.
https://github.com/Avnet/bdf/tree/master/ultra96v2/1.1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org