[GitHub] [bookkeeper] reddycharan commented on a change in pull request #2166: Enhance deferLedgerLockReleaseOfFailedLedger in ReplicationWorker

[GitBox <gi...@apache.org>]

reddycharan commented on a change in pull request #2166: Enhance deferLedgerLockReleaseOfFailedLedger in ReplicationWorker
URL: https://github.com/apache/bookkeeper/pull/2166#discussion_r327743604
 
 

 ##########
 File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestLedgerFragmentReplication.java
 ##########
 @@ -111,7 +111,7 @@ public void testReplicateLFShouldCopyFailedBookieFragmentsToTargetBookie()
         // 0-9 entries should be copy to new bookie
 
         for (LedgerFragment lf : result) {
-            admin.replicateLedgerFragment(lh, lf);
+            admin.replicateLedgerFragment(lh, lf, null);
 
 Review comment:
   @eolivelli even I've mixed opinions about this null thing. In retrospect, instead of passing ConcurrentSet it would be better if I pass function (callback) to the bottom of stack and call this function incase of read failure. So callers can decide what they want to have in their callback logic. Here instead of passing null, it can pass no-op function.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services