You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/02/20 09:49:25 UTC
[GitHub] [cloudstack] ustcweizhou opened a new pull request #3900: 4.14
systemvm root disk size
ustcweizhou opened a new pull request #3900: 4.14 systemvm root disk size
URL: https://github.com/apache/cloudstack/pull/3900
## Description
<!--- Describe your changes in detail -->
The official systemvm template has very few free spaces, it would be better to make the disk size configuration.
Main changes in systemvm template
(1) remove /var and /tmp partitions
(2) move / partition to the last.
(3) install cloud-guest-utils to support "growpart"
other changes
(3) add global setting systemvm.root.disk.size
(4) when systemvm starts, allocate all free spaces on disk to the extend partition, root partition (/dev/vda6) and file system.
This applies on all systemvms (cpvm,ssvm,virtual routers, etc)
This fixes #3455
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [X] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
1. build new systemvm template
2. register new systemvm template
3. change type from "USER" to "SYSTEM"
4. change global setting systemvm.root.disk.size to 3GB
5. destroy ssvm or cpvm
6. new ssvm/cpvm will have 3GB disk and 1.5GB free space on filesystem.
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3900: systemvm: configurable
root disk size based on new systemvm template definition
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3900: systemvm: configurable root disk size based on new systemvm template definition
URL: https://github.com/apache/cloudstack/pull/3900#issuecomment-589531987
Thanks per your comment assigned against 4.15 @weizhouapache
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3900: 4.14 systemvm
root disk size
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #3900: 4.14 systemvm root disk size
URL: https://github.com/apache/cloudstack/pull/3900#issuecomment-588890755
@rhtyd
if the specified value is small than template size, then it will not be used. "-1" and "0" makes no difference actually.
```
Long size = _tmpltMgr.getTemplateSize(template.getId(), vm.getDataCenterId());
if (rootDisksize != null) {
rootDisksize = rootDisksize * 1024 * 1024 * 1024;
if (rootDisksize > size) {
s_logger.debug("Using root disk size of " + rootDisksize + " Bytes for volume " + name);
size = rootDisksize;
} else {
s_logger.debug("Using root disk size of " + size + " Bytes for volume " + name + "since specified root disk size of " + rootDisksize + " Bytes is smaller than template");
}
}
```
https://github.com/apache/cloudstack/blob/master/engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java#L713-L722
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3900: 4.14 systemvm
root disk size
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3900: 4.14 systemvm root disk size
URL: https://github.com/apache/cloudstack/pull/3900#issuecomment-589015238
hm, I think you want milestone 4.14 for this one as well, right @weizhouapache ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3900: systemvm:
configurable root disk size based on new systemvm template definition
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #3900: systemvm: configurable root disk size based on new systemvm template definition
URL: https://github.com/apache/cloudstack/pull/3900#issuecomment-589120674
> hm, I think you want milestone 4.14 for this one as well, right @weizhouapache ?
@DaanHoogland I expect to add to 4.14. However, it require to build new systemvm template (and test it).
4.15 is also good for me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on issue #3900: 4.14 systemvm
root disk size
Posted by GitBox <gi...@apache.org>.
ustcweizhou commented on issue #3900: 4.14 systemvm root disk size
URL: https://github.com/apache/cloudstack/pull/3900#issuecomment-588869865
@rhtyd this has some small conflicts with your PR #3797
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services