You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/08 00:25:58 UTC
[GitHub] [pulsar] ericsyh opened a new pull request #14590: fix(docs): add missing config in debezium mysql source
ericsyh opened a new pull request #14590:
URL: https://github.com/apache/pulsar/pull/14590
Signed-off-by: Eric Shen <er...@outlook.com>
<!--
### Contribution Checklist
- Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
Skip *Issue XYZ* if there is no associated github issue for this pull request.
Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
### Motivation
The YAML sample of debezium mysql source missing a config of `pulsar.service.url` on [io-debezium-source](https://pulsar.apache.org/docs/en/io-debezium-source/#usage)
### Modifications
Add the missing config of `pulsar.service.url`
### Verifying this change
- [x] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
- [ ] `doc-required`
(If you need help on updating docs, create a doc issue)
- [ ] `no-need-doc`
(Please explain why)
- [x] `doc`
(If this PR contains doc changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ericsyh commented on a change in pull request #14590: fix(docs): add missing config in debezium mysql source
Posted by GitBox <gi...@apache.org>.
ericsyh commented on a change in pull request #14590:
URL: https://github.com/apache/pulsar/pull/14590#discussion_r821286426
##########
File path: site2/docs/io-cdc-debezium.md
##########
@@ -92,7 +92,7 @@ You can use one of the following methods to create a configuration file.
database.history: "org.apache.pulsar.io.debezium.PulsarDatabaseHistory"
database.history.pulsar.topic: "history-topic"
database.history.pulsar.service.url: "pulsar://127.0.0.1:6650"
-
+ pulsar.service.url: "pulsar://127.0.0.1:6650"
Review comment:
Yes, i just checked the code and also not found the `pulsar.service.url`. In my test i used the sample YAML on https://pulsar.apache.org/docs/en/io-debezium-source/#configuration-1 but functions gave me an ERROR about the missing config of `pulsar.service.url` then i noticed the following sample
```
bin/pulsar-admin source localrun \
--archive connectors/pulsar-io-debezium-mysql-2.9.1.nar \
--name debezium-mysql-source --destination-topic-name debezium-mysql-topic \
--tenant public \
--namespace default \
--source-config '{"database.hostname": "localhost","database.port": "3306","database.user": "debezium","database.password": "dbz","database.server.id": "184054","database.server.name": "dbserver1","database.whitelist": "inventory","database.history": "org.apache.pulsar.io.debezium.PulsarDatabaseHistory","database.history.pulsar.topic": "history-topic","database.history.pulsar.service.url": "pulsar://127.0.0.1:6650","key.converter": "org.apache.kafka.connect.json.JsonConverter","value.converter": "org.apache.kafka.connect.json.JsonConverter","pulsar.service.url": "pulsar://127.0.0.1:6650","offset.storage.topic": "offset-topic"}'
```
Used the config of `"pulsar.service.url": "pulsar://127.0.0.1:6650"` and i also added it then passed the test.
I will do the test again to verify it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 edited a comment on pull request #14590: fix(docs): add missing config in debezium mysql source
Posted by GitBox <gi...@apache.org>.
gaoran10 edited a comment on pull request #14590:
URL: https://github.com/apache/pulsar/pull/14590#issuecomment-1061606689
It seems that there is a new configuration `database.history.pulsar.service.url` after `2.9.1`. Please take a look at the PR https://github.com/apache/pulsar/pull/11251. Maybe you need to modify the docs before `2.9.1`. Could you try to use the `2.9.1`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ericsyh commented on pull request #14590: fix(docs): add missing config in debezium mysql source
Posted by GitBox <gi...@apache.org>.
ericsyh commented on pull request #14590:
URL: https://github.com/apache/pulsar/pull/14590#issuecomment-1062487557
> It seems that there is a new configuration `database.history.pulsar.service.url` after `2.9.1`. Please take a look at the PR #11251. Maybe you need to modify the docs before `2.9.1`. Could you try to use the `2.9.1`?
OK, i will test in on `2.9.1` later. Now seems the problem is debezium connectors docs is not fully accurate, the `database.history.pulsar.service.url` config only apply for `2.9.x` and previously version should still use `pulsar.service.url`. But previsou docs also change this to use `database.history.pulsar.service.url` config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ericsyh commented on pull request #14590: fix(docs): add missing config in debezium mysql source
Posted by GitBox <gi...@apache.org>.
ericsyh commented on pull request #14590:
URL: https://github.com/apache/pulsar/pull/14590#issuecomment-1061438778
@gaoran10 @nodece Pulsar and debezium-mysql uses `2.8.1`, the ERROR from functions is like below:
```
13:59:00.824 [public/default/debezium-mysql-source-0] ERROR org.apache.pulsar.functions.instance.JavaInstanceRunnable - Source open produced uncaught exception:
java.lang.IllegalArgumentException: Pulsar service URL not provided.
at org.apache.pulsar.io.debezium.DebeziumSource.open(DebeziumSource.java:84) ~[pulsar-io-debezium-core-2.8.1.jar:2.8.1]
at org.apache.pulsar.functions.instance.JavaInstanceRunnable.setupInput(JavaInstanceRunnable.java:735) [org.apache.pulsar-pulsar-functions-instance-2.8.1.jar:?]
at org.apache.pulsar.functions.instance.JavaInstanceRunnable.setup(JavaInstanceRunnable.java:219) [org.apache.pulsar-pulsar-functions-instance-2.8.1.jar:?]
at org.apache.pulsar.functions.instance.JavaInstanceRunnable.run(JavaInstanceRunnable.java:243) [org.apache.pulsar-pulsar-functions-instance-2.8.1.jar:?]
at java.lang.Thread.run(Thread.java:748) [?:1.8.0_292]
13:59:00.829 [public/default/debezium-mysql-source-0] ERROR org.apache.pulsar.functions.instance.JavaInstanceRunnable - [public/default/debezium-mysql-source:0] Uncaught exception in Java Instance
java.lang.IllegalArgumentException: Pulsar service URL not provided.
at org.apache.pulsar.io.debezium.DebeziumSource.open(DebeziumSource.java:84) ~[?:?]
at org.apache.pulsar.functions.instance.JavaInstanceRunnable.setupInput(JavaInstanceRunnable.java:735) ~[org.apache.pulsar-pulsar-functions-instance-2.8.1.jar:?]
at org.apache.pulsar.functions.instance.JavaInstanceRunnable.setup(JavaInstanceRunnable.java:219) ~[org.apache.pulsar-pulsar-functions-instance-2.8.1.jar:?]
at org.apache.pulsar.functions.instance.JavaInstanceRunnable.run(JavaInstanceRunnable.java:243) [org.apache.pulsar-pulsar-functions-instance-2.8.1.jar:?]
at java.lang.Thread.run(Thread.java:748) [?:1.8.0_292]
```
The `mysql.yaml` config file is
```
tenant: "public"
namespace: "default"
name: "debezium-mysql-source"
topicName: "debezium-mysql-topic"
archive: "connectors/pulsar-io-debezium-mysql-2.8.1.nar"
parallelism: 1
configs:
## config for mysql, docker image: debezium/example-mysql:0.8
database.hostname: "x.x.x.x"
database.port: "3306"
database.user: "ericsyh"
database.password: "x.x.x.x.x.x"
database.server.id: "1840"
database.server.name: "streamnative"
database.whitelist: "pulsar"
database.history: "org.apache.pulsar.io.debezium.PulsarDatabaseHistory"
database.history.pulsar.topic: "history-topic"
database.history.pulsar.service.url: "pulsar://127.0.0.1:6650"
## KEY_CONVERTER_CLASS_CONFIG, VALUE_CONVERTER_CLASS_CONFIG
key.converter: "org.apache.kafka.connect.json.JsonConverter"
value.converter: "org.apache.kafka.connect.json.JsonConverter"
## OFFSET_STORAGE_TOPIC_CONFIG
offset.storage.topic: "offset-topic"
```
The status for the sources
```
{
"numInstances" : 1,
"numRunning" : 0,
"instances" : [ {
"instanceId" : 0,
"status" : {
"running" : false,
"error" : "UNAVAILABLE: io exception",
"numRestarts" : 0,
"numReceivedFromSource" : 0,
"numSystemExceptions" : 0,
"latestSystemExceptions" : [ ],
"numSourceExceptions" : 0,
"latestSourceExceptions" : [ ],
"numWritten" : 0,
"lastReceivedTime" : 0,
"workerId" : "standalone"
}
} ]
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on pull request #14590: fix(docs): add missing config in debezium mysql source
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on pull request #14590:
URL: https://github.com/apache/pulsar/pull/14590#issuecomment-1061384940
Could you provide the error logs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 edited a comment on pull request #14590: fix(docs): add missing config in debezium mysql source
Posted by GitBox <gi...@apache.org>.
gaoran10 edited a comment on pull request #14590:
URL: https://github.com/apache/pulsar/pull/14590#issuecomment-1061606689
It seems that there is a new configuration `database.history.pulsar.service.url` after `2.9.1`. Please check the PR https://github.com/apache/pulsar/pull/11251. Maybe you need to modify the docs before `2.9.1`. Could you try to use the `2.9.1`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece commented on a change in pull request #14590: fix(docs): add missing config in debezium mysql source
Posted by GitBox <gi...@apache.org>.
nodece commented on a change in pull request #14590:
URL: https://github.com/apache/pulsar/pull/14590#discussion_r821281445
##########
File path: site2/docs/io-cdc-debezium.md
##########
@@ -92,7 +92,7 @@ You can use one of the following methods to create a configuration file.
database.history: "org.apache.pulsar.io.debezium.PulsarDatabaseHistory"
database.history.pulsar.topic: "history-topic"
database.history.pulsar.service.url: "pulsar://127.0.0.1:6650"
-
+ pulsar.service.url: "pulsar://127.0.0.1:6650"
Review comment:
I don't find any code to read `pulsar.service.url`, could you provide this code? The `database.history.pulsar.service.url` is correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece commented on pull request #14590: fix(docs): add missing config in debezium mysql source
Posted by GitBox <gi...@apache.org>.
nodece commented on pull request #14590:
URL: https://github.com/apache/pulsar/pull/14590#issuecomment-1062493874
We can add a compatible for old configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on pull request #14590: fix(docs): add missing config in debezium mysql source
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on pull request #14590:
URL: https://github.com/apache/pulsar/pull/14590#issuecomment-1061606689
It seems that there is a new configuration after `2.9.1`. Please check the PR https://github.com/apache/pulsar/pull/11251. Maybe you need to modify the docs before `2.9.1`. Could you try to use the `2.9.1`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org