You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by cp...@apache.org on 2020/11/02 15:21:42 UTC
[lucene-solr] branch branch_8x updated: SOLR-14937: Correct
client.queryDefaults().set(...) calls in some JSON facet tests. (#2031)
This is an automated email from the ASF dual-hosted git repository.
cpoerschke pushed a commit to branch branch_8x
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git
The following commit(s) were added to refs/heads/branch_8x by this push:
new aabbbdc SOLR-14937: Correct client.queryDefaults().set(...) calls in some JSON facet tests. (#2031)
aabbbdc is described below
commit aabbbdc928a1e74510c3526ebb31f2e7a88bdac1
Author: Christine Poerschke <cp...@apache.org>
AuthorDate: Mon Nov 2 15:21:14 2020 +0000
SOLR-14937: Correct client.queryDefaults().set(...) calls in some JSON facet tests. (#2031)
---
.../apache/solr/search/facet/TestJsonFacetRefinement.java | 12 ++++++------
.../test/org/apache/solr/search/facet/TestJsonFacets.java | 4 ++--
.../org/apache/solr/search/facet/TestJsonRangeFacets.java | 8 ++++----
3 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/solr/core/src/test/org/apache/solr/search/facet/TestJsonFacetRefinement.java b/solr/core/src/test/org/apache/solr/search/facet/TestJsonFacetRefinement.java
index babc91c..e7fcd27 100644
--- a/solr/core/src/test/org/apache/solr/search/facet/TestJsonFacetRefinement.java
+++ b/solr/core/src/test/org/apache/solr/search/facet/TestJsonFacetRefinement.java
@@ -506,7 +506,7 @@ public class TestJsonFacetRefinement extends SolrTestCaseHS {
initServers();
final Client client = servers.getClient(random().nextInt());
- client.queryDefaults().set("shards", servers.getShards(), "debugQuery", Boolean.toString(random().nextBoolean()));
+ client.queryDefaults().set("shards", servers.getShards()).set("debugQuery", Boolean.toString(random().nextBoolean()));
List<SolrClient> clients = client.getClientProvider().all();
assertTrue(clients.size() >= 3); // we only use 2, but assert 3 to also test empty shard
@@ -596,7 +596,7 @@ public class TestJsonFacetRefinement extends SolrTestCaseHS {
public void testSortedFacetRefinementPushingNonRefinedBucketBackIntoTopN() throws Exception {
initServers();
final Client client = servers.getClient(random().nextInt());
- client.queryDefaults().set("shards", servers.getShards(), "debugQuery", Boolean.toString(random().nextBoolean()));
+ client.queryDefaults().set("shards", servers.getShards()).set("debugQuery", Boolean.toString(random().nextBoolean()));
List<SolrClient> clients = client.getClientProvider().all();
assertTrue(clients.size() >= 3); // we only use 2, but assert 3 to also test empty shard
@@ -828,7 +828,7 @@ public class TestJsonFacetRefinement extends SolrTestCaseHS {
public void testProcessEmptyRefinement() throws Exception {
initServers();
final Client client = servers.getClient(random().nextInt());
- client.queryDefaults().set("shards", servers.getShards(), "debugQuery", Boolean.toString(random().nextBoolean()));
+ client.queryDefaults().set("shards", servers.getShards()).set("debugQuery", Boolean.toString(random().nextBoolean()));
List<SolrClient> clients = client.getClientProvider().all();
assertTrue(clients.size() >= 3); // we only use 2, but assert at least 3 to also test empty shard
@@ -884,7 +884,7 @@ public class TestJsonFacetRefinement extends SolrTestCaseHS {
private int initSomeDocsWhere1ShardHasOnlyParentFacetField() throws Exception {
initServers();
final Client client = servers.getClient(random().nextInt());
- client.queryDefaults().set("shards", servers.getShards(), "debugQuery", Boolean.toString(random().nextBoolean()));
+ client.queryDefaults().set("shards", servers.getShards()).set("debugQuery", Boolean.toString(random().nextBoolean()));
final List<SolrClient> clients = client.getClientProvider().all();
assertTrue(clients.size() >= 2);
@@ -1043,7 +1043,7 @@ public class TestJsonFacetRefinement extends SolrTestCaseHS {
public void doBasicRefinement(ModifiableSolrParams p) throws Exception {
initServers();
Client client = servers.getClient(random().nextInt());
- client.queryDefaults().set("shards", servers.getShards(), "debugQuery", Boolean.toString(random().nextBoolean()));
+ client.queryDefaults().set("shards", servers.getShards()).set("debugQuery", Boolean.toString(random().nextBoolean()));
List<SolrClient> clients = client.getClientProvider().all();
assertTrue(clients.size() >= 3);
@@ -1476,7 +1476,7 @@ public class TestJsonFacetRefinement extends SolrTestCaseHS {
public void testIndexAscRefineConsistency() throws Exception {
initServers();
final Client client = servers.getClient(random().nextInt());
- client.queryDefaults().set("shards", servers.getShards(), "debugQuery", Boolean.toString(random().nextBoolean()));
+ client.queryDefaults().set("shards", servers.getShards()).set("debugQuery", Boolean.toString(random().nextBoolean()));
List<SolrClient> clients = client.getClientProvider().all();
assertTrue(clients.size() >= 3);
diff --git a/solr/core/src/test/org/apache/solr/search/facet/TestJsonFacets.java b/solr/core/src/test/org/apache/solr/search/facet/TestJsonFacets.java
index b26cdc6..acce852 100644
--- a/solr/core/src/test/org/apache/solr/search/facet/TestJsonFacets.java
+++ b/solr/core/src/test/org/apache/solr/search/facet/TestJsonFacets.java
@@ -1104,7 +1104,7 @@ public class TestJsonFacets extends SolrTestCaseHS {
public void testStatsDistrib() throws Exception {
initServers();
Client client = servers.getClient(random().nextInt());
- client.queryDefaults().set( "shards", servers.getShards(), "debugQuery", Boolean.toString(random().nextBoolean()) );
+ client.queryDefaults().set( "shards", servers.getShards()).set("debugQuery", Boolean.toString(random().nextBoolean()) );
doStats( client, params() );
}
@@ -2950,7 +2950,7 @@ public class TestJsonFacets extends SolrTestCaseHS {
public void testOverrequest() throws Exception {
initServers();
Client client = servers.getClient(random().nextInt());
- client.queryDefaults().set( "shards", servers.getShards(), "debugQuery", Boolean.toString(random().nextBoolean()) );
+ client.queryDefaults().set( "shards", servers.getShards()).set("debugQuery", Boolean.toString(random().nextBoolean()) );
List<SolrClient> clients = client.getClientProvider().all();
assertTrue(clients.size() >= 3);
diff --git a/solr/core/src/test/org/apache/solr/search/facet/TestJsonRangeFacets.java b/solr/core/src/test/org/apache/solr/search/facet/TestJsonRangeFacets.java
index 0d21636..145b84b 100644
--- a/solr/core/src/test/org/apache/solr/search/facet/TestJsonRangeFacets.java
+++ b/solr/core/src/test/org/apache/solr/search/facet/TestJsonRangeFacets.java
@@ -87,7 +87,7 @@ public class TestJsonRangeFacets extends SolrTestCaseHS {
public void testRangeOtherWhiteboxDistrib() throws Exception {
initServers();
Client client = servers.getClient(random().nextInt());
- client.queryDefaults().set( "shards", servers.getShards(), "debugQuery", Boolean.toString(random().nextBoolean()) );
+ client.queryDefaults().set( "shards", servers.getShards()).set("debugQuery", Boolean.toString(random().nextBoolean()) );
}
public void testRangeOtherWhitebox() throws Exception {
@@ -167,7 +167,7 @@ public class TestJsonRangeFacets extends SolrTestCaseHS {
public void testDateFacetsDistrib() throws Exception {
initServers();
Client client = servers.getClient(random().nextInt());
- client.queryDefaults().set( "shards", servers.getShards(), "debugQuery", Boolean.toString(random().nextBoolean()) );
+ client.queryDefaults().set( "shards", servers.getShards()).set("debugQuery", Boolean.toString(random().nextBoolean()) );
doDateFacets(client);
}
@@ -234,7 +234,7 @@ public class TestJsonRangeFacets extends SolrTestCaseHS {
public void testRangeFacetWithRangesDistrib() throws Exception {
initServers();
Client client = servers.getClient(random().nextInt());
- client.queryDefaults().set( "shards", servers.getShards(), "debugQuery", Boolean.toString(random().nextBoolean()) );
+ client.queryDefaults().set( "shards", servers.getShards()).set("debugQuery", Boolean.toString(random().nextBoolean()) );
doRangeFacetWithRanges(client);
}
@@ -304,7 +304,7 @@ public class TestJsonRangeFacets extends SolrTestCaseHS {
public void testRangeFacetWithRangesInNewFormatDistrib() throws Exception {
initServers();
Client client = servers.getClient(random().nextInt());
- client.queryDefaults().set( "shards", servers.getShards(), "debugQuery", Boolean.toString(random().nextBoolean()) );
+ client.queryDefaults().set( "shards", servers.getShards()).set("debugQuery", Boolean.toString(random().nextBoolean()) );
doRangeFacetWithRangesInNewFormat(client);
}