[GitHub] [superset] mvoitko commented on a change in pull request #15340: feat: add possibility to specify Service Account name for the Deployment in the Helm chart

[GitBox <gi...@apache.org>]

mvoitko commented on a change in pull request #15340:
URL: https://github.com/apache/superset/pull/15340#discussion_r658771376



##########
File path: helm/superset/templates/deployment-worker.yaml
##########
@@ -53,6 +53,7 @@ spec:
         app: {{ template "superset.name" . }}-worker
         release: {{ .Release.Name }}
     spec:
+      serviceAccountName: {{ .Values.serviceAccountName }}

Review comment:
       What do you mean by SA name is set? I could check if the value is empty in values then I could skip this. Do you mean smth like:
   ```
   {{ if .Values.serviceAccountName }}
   serviceAccountName: {{ .Values.serviceAccountName }}
   {{ end }}
   ```
   But i would prefer to eliminate "if" statements to make code more clear




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org